webrtc/modules/rtp_rtcp/source/rtcp_packet.cc - Issue 1309833002: Send RTCP packets via RtcpPacket callback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet.cc

Issue 1309833002: Send RTCP packets via RtcpPacket callback (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Send RTCP messags directly via callback, refactoring, rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/rtp_rtcp/source/rtcp_packet.cc

diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet.cc b/webrtc/modules/rtp_rtcp/source/rtcp_packet.cc

index d25a754f415215998f9c5a4be26d895b0587278f..86b040fb00d45bbc5d0d292645214409fee7180f 100644

--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet.cc

+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet.cc

@@ -685,11 +685,6 @@ rtc::scoped_ptr<RawPacket> RtcpPacket::Build() const {

return packet;

}

-bool RtcpPacket::Build(PacketReadyCallback* callback) const {

- uint8_t buffer[IP_PACKET_SIZE];

- return BuildExternalBuffer(buffer, IP_PACKET_SIZE, callback);

bool RtcpPacket::BuildExternalBuffer(uint8_t* buffer,

size_t max_length,

PacketReadyCallback* callback) const {