Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1309663007: GN: Fix iOS build. (Closed)

Created:
5 years, 3 months ago by kjellander_webrtc
Modified:
5 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, perkj_webrtc, mflodman, sherouk, sdefresne
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN: Fix iOS build. This makes it possible to run GN for the iOS build, which is being worked on for Chromium. For the command below to work https://codereview.chromium.org/1314413006/ needs to be rolled into WebRTC. TESTED=gn gen out/Default --args="build_with_chromium=false target_os=\"ios\"" BUG=chromium:459705 R=dpranke@chromium.org Committed: https://chromium.googlesource.com/external/webrtc/+/11e498545b3f574030f9bf025f4fc5cd512b1b84

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M webrtc/base/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_render/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
kjellander_webrtc
This combined with an opus CL should replace https://codereview.webrtc.org/1320643004
5 years, 3 months ago (2015-09-09 20:10:06 UTC) #2
Dirk Pranke
lgtm, but fix the description since opus isn't at fault and you need https://codereview.chromium.org/1314413006 instead.
5 years, 3 months ago (2015-09-09 20:20:52 UTC) #3
kjellander_webrtc
On 2015/09/09 20:20:52, Dirk Pranke wrote: > lgtm, but fix the description since opus isn't ...
5 years, 3 months ago (2015-09-09 20:21:29 UTC) #4
kjellander_webrtc
5 years, 3 months ago (2015-09-09 20:22:47 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
11e498545b3f574030f9bf025f4fc5cd512b1b84 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698