Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1309313008: Revert "Move test cases for more natural ordering" (Closed)

Created:
5 years, 3 months ago by stefan-webrtc
Modified:
5 years, 3 months ago
Reviewers:
the sun
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Speculative revert of "Move test cases for more natural ordering." This reverts commit c20a5dc9305b988ca173cd63e606124b02e6d54c. BUG=webrtc:4959 R=solenberg@webrtc.org TBR=solenberg@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/02d283a6ff5364d94aa88f5f5df4cfd3a5411346

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+359 lines, -287 lines) Patch
M talk/media/base/videoengine_unittest.h View 2 chunks +26 lines, -0 lines 0 comments Download
M talk/media/webrtc/webrtcvideoengine2_unittest.cc View 3 chunks +155 lines, -145 lines 0 comments Download
M talk/media/webrtc/webrtcvoiceengine.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M talk/media/webrtc/webrtcvoiceengine_unittest.cc View 4 chunks +174 lines, -142 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
stefan-webrtc
5 years, 3 months ago (2015-09-01 12:02:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309313008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309313008/1
5 years, 3 months ago (2015-09-01 12:02:59 UTC) #3
stefan-webrtc
Committed patchset #1 (id:1) manually as 02d283a6ff5364d94aa88f5f5df4cfd3a5411346 (presubmit successful).
5 years, 3 months ago (2015-09-01 13:48:38 UTC) #4
rmistry
5 years, 3 months ago (2015-09-03 16:57:39 UTC) #5
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/1309903007/ by rmistry@google.com.

The reason for reverting is: Not really reverting. Just testing the revert
button for https://code.google.com/p/chromium/issues/detail?id=527325.

Powered by Google App Engine
This is Rietveld 408576698