Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 1309143007: Fix ScreenCapturerWinGdi to handle DesktopFrameWin::Create() errors. (Closed)

Created:
5 years, 3 months ago by Sergey Ulanov
Modified:
5 years, 3 months ago
Reviewers:
jiayl, jiayl2
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix ScreenCapturerWinGdi to handle DesktopFrameWin::Create() errors. DesktopFrameWin::Create() may return nullptr when it fails to allocate windows bitmap. ScreenCapturerWinGdi wasn't handling that case properly. BUG=527660 Committed: https://crrev.com/d5ae6ae6b5599fb47a17656ec092ff923609a8d2 Cr-Commit-Position: refs/heads/master@{#9865}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M webrtc/modules/desktop_capture/win/screen_capturer_win_gdi.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
Sergey Ulanov
5 years, 3 months ago (2015-09-04 20:30:15 UTC) #3
jiayl
lgtm
5 years, 3 months ago (2015-09-04 20:35:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309143007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309143007/20001
5 years, 3 months ago (2015-09-04 20:57:50 UTC) #6
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 3 months ago (2015-09-04 20:57:51 UTC) #8
jiayl2
lgtm
5 years, 3 months ago (2015-09-04 20:58:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309143007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309143007/20001
5 years, 3 months ago (2015-09-04 20:59:19 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
5 years, 3 months ago (2015-09-04 22:59:30 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309143007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309143007/20001
5 years, 3 months ago (2015-09-05 01:37:19 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 3 months ago (2015-09-05 01:38:12 UTC) #17
commit-bot: I haz the power
5 years, 3 months ago (2015-09-05 01:38:25 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d5ae6ae6b5599fb47a17656ec092ff923609a8d2
Cr-Commit-Position: refs/heads/master@{#9865}

Powered by Google App Engine
This is Rietveld 408576698