Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1309073004: Add JNI/java wrapper for the file rotating logging class. (Closed)

Created:
5 years, 3 months ago by jiayl2
Modified:
5 years, 3 months ago
Reviewers:
AlexG, AlexGlaznev
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add JNI/java wrapper for the file rotating logging class. BUG= R=glaznev@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/e63d2a1c627566682512ca73c944c8a46e931e90

Patch Set 1 #

Total comments: 4

Patch Set 2 : CR #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -16 lines) Patch
M talk/app/webrtc/java/jni/peerconnection_jni.cc View 1 3 chunks +67 lines, -0 lines 0 comments Download
A + talk/app/webrtc/java/src/org/webrtc/CallSessionFileRotatingLogSink.java View 2 chunks +18 lines, -16 lines 0 comments Download
M talk/app/webrtc/java/src/org/webrtc/Logging.java View 2 chunks +14 lines, -0 lines 0 comments Download
M talk/libjingle.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
jiayl2
PTAL
5 years, 3 months ago (2015-09-01 21:54:26 UTC) #2
AlexG
lgtm https://codereview.webrtc.org/1309073004/diff/1/talk/app/webrtc/java/jni/peerconnection_jni.cc File talk/app/webrtc/java/jni/peerconnection_jni.cc (right): https://codereview.webrtc.org/1309073004/diff/1/talk/app/webrtc/java/jni/peerconnection_jni.cc#newcode75 talk/app/webrtc/java/jni/peerconnection_jni.cc:75: #include "webrtc/base/logsinks.h" Extra space? https://codereview.webrtc.org/1309073004/diff/1/talk/app/webrtc/java/jni/peerconnection_jni.cc#newcode1733 talk/app/webrtc/java/jni/peerconnection_jni.cc:1733: delete sink; ...
5 years, 3 months ago (2015-09-01 22:31:23 UTC) #4
jiayl2
https://codereview.webrtc.org/1309073004/diff/1/talk/app/webrtc/java/jni/peerconnection_jni.cc File talk/app/webrtc/java/jni/peerconnection_jni.cc (right): https://codereview.webrtc.org/1309073004/diff/1/talk/app/webrtc/java/jni/peerconnection_jni.cc#newcode75 talk/app/webrtc/java/jni/peerconnection_jni.cc:75: #include "webrtc/base/logsinks.h" On 2015/09/01 22:31:23, AlexG wrote: > Extra ...
5 years, 3 months ago (2015-09-01 22:40:09 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309073004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309073004/20001
5 years, 3 months ago (2015-09-01 22:40:34 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/579)
5 years, 3 months ago (2015-09-01 22:43:00 UTC) #9
jiayl2
5 years, 3 months ago (2015-09-01 23:11:32 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
e63d2a1c627566682512ca73c944c8a46e931e90 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698