AndroidVideoCapturer: Delegate framerate choice to VideoCapturerAndroid.java

AndroidVideoCapturer: Delegate framerate choice to VideoCapturerAndroid.java

webrtc::VideoSource resolves the kMaxFrameRate constraint by capping the desired framerate to kMaxFrameRate. That framerate is then passed into cricket::VideoCapturer::GetBestCaptureFormat(). The default implementation will choose a format from the supported formats list. Instead, we should override this function in AndroidVideoCapturer to give VideoCapturerAndroid.java the opportunity to choose a suitable framerate range.

BUG=webrtc:4938
R=glaznev@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/6ec1f921b1186127467393dc82c0a786e0de4e2b

[magjed_webrtc, 2015-08-27 10:42:12]

magjed@webrtc.org changed reviewers:
+ glaznev@webrtc.org

[magjed_webrtc, 2015-08-27 13:50:23]

Please take a look.

https://codereview.webrtc.org/1308953004/diff/20001/talk/app/webrtc/videosour...
File talk/app/webrtc/videosource.cc (left):

https://codereview.webrtc.org/1308953004/diff/20001/talk/app/webrtc/videosour...
talk/app/webrtc/videosource.cc:164: return false;
I removed this because it looks like a bug to me. We should not filter out
formats where supportedFps < constraint.kMaxFrameRate.

[AlexG, 2015-08-27 18:22:18]

lgtm

[magjed_webrtc, 2015-08-28 08:09:44]

The CQ bit was checked by magjed@webrtc.org

[commit-bot: I haz the power, 2015-08-28 08:09:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1308953004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1308953004/20001

[magjed_webrtc, 2015-08-28 09:41:12]

Committed patchset #2 (id:20001) manually as
6ec1f921b1186127467393dc82c0a786e0de4e2b (presubmit successful).