Add a base class to Wav{Reader,Writer} to access shared parameters.

Add a base class to Wav{Reader,Writer} to access shared parameters.

Use it to clean up some code in audioproc_float.cc.

R=kwiberg@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/bc2296de9e3680032d6c632750d7551704cf3f06

[Andrew MacDonald, 2015-08-21 16:54:57]

andrew@webrtc.org changed reviewers:
+ kwiberg@webrtc.org

[kwiberg-webrtc, 2015-08-24 12:13:48]

It doesn't seem to buy you that much, but it doesn't cost that much either, so
lgtm.

https://codereview.webrtc.org/1308893002/diff/40001/webrtc/common_audio/wav_f...
File webrtc/common_audio/wav_file.h (right):

https://codereview.webrtc.org/1308893002/diff/40001/webrtc/common_audio/wav_f...
webrtc/common_audio/wav_file.h:29: virtual uint32_t num_samples() const = 0;
One might argue that these should have CamelCase names, since the implementation
is by design decoupled from the implementation.

[Andrew MacDonald, 2015-08-24 19:50:57]

https://codereview.webrtc.org/1308893002/diff/40001/webrtc/common_audio/wav_f...
File webrtc/common_audio/wav_file.h (right):

https://codereview.webrtc.org/1308893002/diff/40001/webrtc/common_audio/wav_f...
webrtc/common_audio/wav_file.h:29: virtual uint32_t num_samples() const = 0;
On 2015/08/24 12:13:48, kwiberg-webrtc wrote:
> One might argue that these should have CamelCase names, since the
implementation
> is by design decoupled from the implementation.

A not unreasonable argument, but I would counter that the existing style
correctly hints implementors to make these cheap.

[Andrew MacDonald, 2015-08-24 19:51:04]

The CQ bit was checked by andrew@webrtc.org

[commit-bot: I haz the power, 2015-08-24 19:51:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1308893002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1308893002/40001

[commit-bot: I haz the power, 2015-08-24 19:52:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-24 19:52:38]

Try jobs failed on following builders:
  linux_gn on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_gn/builds/5173)
  mac_x64_gn_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_x64_gn_rel/builds/3568)

[Andrew MacDonald, 2015-08-24 20:00:04]

Patchset #4 (id:60001) has been deleted

[Andrew MacDonald, 2015-08-24 20:00:57]

The CQ bit was checked by andrew@webrtc.org

[Andrew MacDonald, 2015-08-24 20:00:57]

The patchset sent to the CQ was uploaded after l-g-t-m from kwiberg@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1308893002/#ps80001 (title:
"Add virtual destructor.")

[commit-bot: I haz the power, 2015-08-24 20:01:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1308893002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1308893002/80001

[commit-bot: I haz the power, 2015-08-24 22:01:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-24 22:01:20]

Try jobs failed on following builders:
  mac_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[Andrew MacDonald, 2015-08-24 23:39:29]

The CQ bit was checked by andrew@webrtc.org

[commit-bot: I haz the power, 2015-08-24 23:39:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1308893002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1308893002/80001

[Andrew MacDonald, 2015-08-25 00:20:34]

The CQ bit was unchecked by andrew@webrtc.org

[Andrew MacDonald, 2015-08-25 00:29:40]

Committed patchset #4 (id:80001) manually as
bc2296de9e3680032d6c632750d7551704cf3f06 (presubmit successful).