Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 1308753006: VP9 codec controls for screensharing (Closed)

Created:
5 years, 3 months ago by ivica
Modified:
5 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, stefan-webrtc, mflodman, sprang_webrtc, marpan2
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

VP9 codec controls for screensharing Telling the encoder to adjust the parameters for the screen content. Also, telling the encoder to skip the encoding of very flat/low content blocks. For now only for screensharing. (number 8 in VP8E_SET_STATIC_THRESHOLD is correct) Committed: https://crrev.com/242d6384c45f9251229561552afd77d9c0e7b0b0 Cr-Commit-Position: refs/heads/master@{#9860}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc View 1 chunk +7 lines, -0 lines 2 comments Download

Messages

Total messages: 14 (5 generated)
ivica
5 years, 3 months ago (2015-09-03 16:45:23 UTC) #2
pbos-webrtc
stefan/sprang@ can either of you cover this? I don't know what this is so I ...
5 years, 3 months ago (2015-09-04 09:29:42 UTC) #4
stefan-webrtc
lgtm https://codereview.webrtc.org/1308753006/diff/1/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc File webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc (right): https://codereview.webrtc.org/1308753006/diff/1/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc#newcode410 webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc:410: // Let the encoder skip the encoding of ...
5 years, 3 months ago (2015-09-04 09:31:51 UTC) #5
ivica
https://codereview.webrtc.org/1308753006/diff/1/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc File webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc (right): https://codereview.webrtc.org/1308753006/diff/1/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc#newcode410 webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc:410: // Let the encoder skip the encoding of very ...
5 years, 3 months ago (2015-09-04 09:40:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308753006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308753006/1
5 years, 3 months ago (2015-09-04 09:40:56 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android on tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_rel on ...
5 years, 3 months ago (2015-09-04 11:41:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308753006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308753006/1
5 years, 3 months ago (2015-09-04 13:12:39 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-04 13:13:27 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-09-04 13:13:39 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/242d6384c45f9251229561552afd77d9c0e7b0b0
Cr-Commit-Position: refs/heads/master@{#9860}

Powered by Google App Engine
This is Rietveld 408576698