Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Unified Diff: webrtc/modules/video_capture/ensure_initialized.cc

Issue 1308693010: Roll chromium_revision f8d6ba9..a28d8d5 (337800:346100) (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master
Patch Set: Adding third_party/lss to links. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/modules/audio_device/android/ensure_initialized.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/video_capture/ensure_initialized.cc
diff --git a/webrtc/modules/video_capture/ensure_initialized.cc b/webrtc/modules/video_capture/ensure_initialized.cc
index 9d43d9f1bdf6c42ccc8191cf2b6b2c3e9cc0b9cc..68cac047f18ae51291f02f72acd543b9fd003da4 100644
--- a/webrtc/modules/video_capture/ensure_initialized.cc
+++ b/webrtc/modules/video_capture/ensure_initialized.cc
@@ -22,8 +22,12 @@ void EnsureInitialized() {}
#include <pthread.h>
+// Note: this dependency is dangerous since it reaches into Chromium's
+// base. You can't include anything in this file that includes WebRTC's
+// base/checks.h, for instance, since it will clash with Chromium's
+// logging.h. Therefore, the CHECKs in this file will actually use
+// Chromium's checks rather than the WebRTC ones.
#include "base/android/jni_android.h"
-#include "webrtc/base/checks.h"
#include "webrtc/modules/video_capture/video_capture_internal.h"
namespace webrtc {
« no previous file with comments | « webrtc/modules/audio_device/android/ensure_initialized.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698