Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1308563004: rtc::Bind: Capture scoped_refptr reference arguments by value (Closed)

Created:
5 years, 4 months ago by magjed_webrtc
Modified:
5 years, 4 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

rtc::Bind: Capture scoped_refptr reference arguments by value R=tommi@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/b274547ebdefd0db470e21cfe113457cabd99dff

Patch Set 1 #

Patch Set 2 : Capture scoped_refptr references by-value instead #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -82 lines) Patch
M webrtc/base/bind.h View 1 13 chunks +54 lines, -42 lines 0 comments Download
M webrtc/base/bind.h.pump View 1 3 chunks +14 lines, -2 lines 0 comments Download
M webrtc/base/bind_unittest.cc View 1 5 chunks +90 lines, -38 lines 1 comment Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308563004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308563004/1
5 years, 4 months ago (2015-08-21 16:38:28 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/builds/1904)
5 years, 4 months ago (2015-08-21 17:06:22 UTC) #5
magjed_webrtc
Please take a look. I also updated the test I added in the previous rtc::Bind ...
5 years, 4 months ago (2015-08-24 14:06:52 UTC) #6
tommi
lgtm. ship it! https://codereview.webrtc.org/1308563004/diff/20001/webrtc/base/bind_unittest.cc File webrtc/base/bind_unittest.cc (right): https://codereview.webrtc.org/1308563004/diff/20001/webrtc/base/bind_unittest.cc#newcode67 webrtc/base/bind_unittest.cc:67: static_assert(is_same<detail::RemoveScopedPtrRef< these are nice
5 years, 4 months ago (2015-08-24 15:43:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308563004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308563004/20001
5 years, 4 months ago (2015-08-25 13:57:27 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_x64_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_x64_rel/builds/8861)
5 years, 4 months ago (2015-08-25 14:12:52 UTC) #11
magjed_webrtc
5 years, 4 months ago (2015-08-25 15:56:41 UTC) #12
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
b274547ebdefd0db470e21cfe113457cabd99dff (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698