Chromium Code Reviews Chromium Code Reviews
Issue
1308403003:
Refactoring full stack and loopback tests (Closed)
DescriptionRefactoring full stack and loopback tests
Refactoring full stack, video and screenshare tests to use the same code basis
for parametrization and initialization. This patch is done on top of recently
commited full stack graphs CL https://codereview.webrtc.org/1289933003/, but
virtually no changes have been made to full_stack_plot.py nor to the VideoAnalyzer
in full stack, except moving it to video_quality_test.cc.
Also, full_stack_samples.cc (build target) was removed and replaced with
-output_filename and -duration cmdline arguments in video_loopback and
screenshare_loopback.
The important things to review:
- video_quality_test.h
Is the structure of Params good? (examples of usage can be found in
full_stack.cc, video_loopback.cc and screenshare_loopback.cc)
- video_quality_test.cc
Is the initialization correct? The case for using Analyzer and using local
renderer are different, can they be further merged?
- webrtc_tests.gypi
Reproducing the different bitrate settings the full stack and loopback tests had
was a little bit tricky. To support both simultaneously, I added BitrateConfig
to the Params struct, as well as separate start_bitrate and target_bitrate flags
for loopback tests.
Note: Side-by-side diff for video_quality_test.cc compares that file directly
with the old full_stack.cc, so changes to VideoAnalyzer are clearly visible.
Note: Recent CL I've committed added -num_temporal_layers and -sl_discard_threshold
args to loopback tests. This was removed here. Support for streams and SVC
will be added in a CL following this one.
Committed: https://crrev.com/5d6a06c1d29a2061bcf4b321ffceab477a404d51
Cr-Commit-Position: refs/heads/master@{#9969}
Patch Set 1 #Patch Set 2 : rebase master (old) and rm full_stack_samples.cc #Patch Set 3 : rebase master (including first graphs commit) #Patch Set 4 : Renaming full_stack_base to video_quality_test #Patch Set 5 : Removing full_stack.h from gyp file #Patch Set 6 : Removing unnecessary includes #Patch Set 7 : cpp standard apparently doesn't like unnamed structs #Patch Set 8 : Fixing casts #Patch Set 9 : Another cast #Patch Set 10 : Adding parentheses #Patch Set 11 : Rebase fixes. Temporarily disabling SLs in loopback tests. #Patch Set 12 : Hopefully fixed the gyp file and the casts. #Patch Set 13 : Disabling a dependency for android only. Rebase master. #
Total comments: 14
Patch Set 14 : Addressing comments #Patch Set 15 : Removing a comment. #
Total comments: 12
Patch Set 16 : Adding some comments #Patch Set 17 : Addressing comments #Patch Set 18 : Fixing perf tests #Patch Set 19 : rebase updates #
Messages
Total messages: 70 (30 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
