Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet.h

Issue 1307663004: Add a ParseHeader method to RtcpPacket, for parsing common RTCP header. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Addressed comments, rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/modules/rtp_rtcp/source/rtcp_packet.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/rtp_rtcp/source/rtcp_packet.h
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet.h b/webrtc/modules/rtp_rtcp/source/rtcp_packet.h
index c5432de9d6030544f4d6ea91405950d1712cbce6..cfbe8cee92952afde9b61c0e3df81a25d1072ab5 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet.h
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet.h
@@ -99,11 +99,11 @@ class RtcpPacket {
size_t max_length,
PacketReadyCallback* callback) const = 0;
- void CreateHeader(uint8_t count_or_format,
- uint8_t packet_type,
- size_t length,
- uint8_t* buffer,
- size_t* pos) const;
+ static void CreateHeader(uint8_t count_or_format,
+ uint8_t packet_type,
+ size_t block_length, // Size in 32bit words - 1.
+ uint8_t* buffer,
+ size_t* pos);
bool OnBufferFull(uint8_t* packet,
size_t* index,
« no previous file with comments | « no previous file | webrtc/modules/rtp_rtcp/source/rtcp_packet.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698