webrtc/BUILD.gn - Issue 1307633008: GN: Fix invalid configuration for Android GCC build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/BUILD.gn

Issue 1307633008: GN: Fix invalid configuration for Android GCC build. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/BUILD.gn

diff --git a/webrtc/BUILD.gn b/webrtc/BUILD.gn

index 05e2e1930626c20612e8cd7114d4a82bf72cd4e1..6aadddb42a7e682b7cea3f21516d8f5c95a76945 100644

--- a/webrtc/BUILD.gn

+++ b/webrtc/BUILD.gn

@@ -156,7 +156,7 @@ config("common_config") {

# TODO(kjellander): Handle warnings on Windows where WebRTC differ from the

pbos-webrtc 2015/09/07 08:27:28 (Should this TODO be here?)

kjellander_webrtc 2015/09/07 10:57:10 No, it comes from the time when I created the GN c

# default warnings set in build/config/compiler/BUILD.gn.

- if (is_android && is_clang) {

+ if (is_android && !is_clang) {

# The Android NDK doesn"t provide optimized versions of these

# functions. Ensure they are disabled for all compilers.

cflags += [

« no previous file with comments | « no previous file | webrtc/build/common.gypi » ('j') | no next file with comments »