GN: Fix invalid configuration for Android GCC build.

webrtc/BUILD.gn

 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 # TODO(kjellander): Rebase this to webrtc/build/common.gypi changes after r6330.
 
@@ skipping 135 matching lines @@
     if (mips_dsp_rev == 1) {
       defines += [ "MIPS_DSP_R1_LE" ]
     } else if (mips_dsp_rev == 2) {
       defines += [
         "MIPS_DSP_R1_LE",
         "MIPS_DSP_R2_LE",
       ]
     }
   }
 
   # TODO(kjellander): Handle warnings on Windows where WebRTC differ from the

[pbos-webrtc, 2015/09/07 08:27:28]

(Should this TODO be here?)

[kjellander_webrtc, 2015/09/07 10:57:10]

No, it comes from the time when I created the GN configs but Windows wasn't
fully supported yet. Today we have GN bots on Windows so this must be obsolete.
Removed in PS#2.

   # default warnings set in build/config/compiler/BUILD.gn.
 
-  if (is_android && is_clang) {
+  if (is_android && !is_clang) {
     # The Android NDK doesn"t provide optimized versions of these
     # functions. Ensure they are disabled for all compilers.
     cflags += [
       "-fno-builtin-cos",
       "-fno-builtin-sin",
       "-fno-builtin-cosf",
       "-fno-builtin-sinf",
     ]
   }
 }
@@ skipping 103 matching lines @@
   if (rtc_enable_protobuf) {
     defines += [ "ENABLE_RTC_EVENT_LOG" ]
     deps += [ ":rtc_event_log_proto" ]
   }
   if (is_clang && !is_nacl) {
     # Suppress warnings from Chrome's Clang plugins.
     # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
     configs -= [ "//build/config/clang:find_bad_constructs" ]
   }
 }