Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 1307633008: GN: Fix invalid configuration for Android GCC build. (Closed)

Created:
5 years, 3 months ago by kjellander_webrtc
Modified:
5 years, 3 months ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN: Fix invalid configuration for Android GCC build. The disabling of the sin,cos,sinf,cosf functions had the wrong condition for GN. This fixes that and also makes the condition in common.gypi a bit more readable. BUG= R=pbos@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/c0c7d2e1ef1deebde1578cd6fea6512ba2d73c45

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed obsolete TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M webrtc/BUILD.gn View 1 1 chunk +1 line, -4 lines 0 comments Download
M webrtc/build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
kjellander_webrtc
5 years, 3 months ago (2015-09-07 07:05:52 UTC) #2
pbos-webrtc
lgtm https://codereview.webrtc.org/1307633008/diff/1/webrtc/BUILD.gn File webrtc/BUILD.gn (right): https://codereview.webrtc.org/1307633008/diff/1/webrtc/BUILD.gn#newcode156 webrtc/BUILD.gn:156: # TODO(kjellander): Handle warnings on Windows where WebRTC ...
5 years, 3 months ago (2015-09-07 08:27:28 UTC) #3
kjellander_webrtc
https://codereview.webrtc.org/1307633008/diff/1/webrtc/BUILD.gn File webrtc/BUILD.gn (right): https://codereview.webrtc.org/1307633008/diff/1/webrtc/BUILD.gn#newcode156 webrtc/BUILD.gn:156: # TODO(kjellander): Handle warnings on Windows where WebRTC differ ...
5 years, 3 months ago (2015-09-07 10:57:10 UTC) #4
kjellander_webrtc
5 years, 3 months ago (2015-09-07 10:58:04 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
c0c7d2e1ef1deebde1578cd6fea6512ba2d73c45 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698