Issue 1306863003: Fix accessing uninitialized variables when not processing a reverse stream.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1306863003: Fix accessing uninitialized variables when not processing a reverse stream. (Closed)

Created:
5 years, 4 months ago by Andrew MacDonald

Modified:
5 years, 4 months ago

Reviewers:
turaj

CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, hlundin-webrtc, kwiberg-webrtc, aluebs-webrtc, bjornv1, ekm

Base URL:
https://chromium.googlesource.com/external/webrtc.git@master

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

More Reviews

Description

Fix accessing uninitialized variables when not processing a reverse stream. TBR=turaj@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/c0775c02910c14743cc46fbd4618de1b20ecc681

Patch Set 2 : git cl format #

Total comments: 1

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -6 lines)			Patch
	M	webrtc/modules/audio_processing/test/audioproc_float.cc	View	1	1 chunk	+9 lines, -6 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Andrew MacDonald

Committed patchset #2 (id:20001) manually as c0775c02910c14743cc46fbd4618de1b20ecc681 (presubmit successful).

5 years, 4 months ago (2015-08-21 16:33:02 UTC) #2

Andrew MacDonald

https://codereview.webrtc.org/1306863003/diff/20001/webrtc/modules/audio_processing/test/audioproc_float.cc File webrtc/modules/audio_processing/test/audioproc_float.cc (right): https://codereview.webrtc.org/1306863003/diff/20001/webrtc/modules/audio_processing/test/audioproc_float.cc#newcode175 webrtc/modules/audio_processing/test/audioproc_float.cc:175: StreamConfig reverse_input_config = {in_rev_file->sample_rate(), This redeclaration is a bug ...

5 years, 4 months ago (2015-08-21 17:31:34 UTC) #3

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages

Issue 1306863003: Fix accessing uninitialized variables when not processing a reverse stream. (Closed)

Description

Patch Set 1 #

Patch Set 2 : git cl format #

Messages