Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Unified Diff: webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.h

Issue 1306813009: H.264 video codec support using OpenH264/FFmpeg (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Addressed noahric's comments + minor fixes Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.h
diff --git a/webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.h b/webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.h
new file mode 100644
index 0000000000000000000000000000000000000000..df807770eda8aa90d62daa4b83a862c132bd9bb9
--- /dev/null
+++ b/webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.h
@@ -0,0 +1,70 @@
+/*
+ * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
+ *
+ * Use of this source code is governed by a BSD-style license
+ * that can be found in the LICENSE file in the root of the source
+ * tree. An additional intellectual property rights grant can be found
+ * in the file PATENTS. All contributing project authors may
+ * be found in the AUTHORS file in the root of the source tree.
+ *
+ */
+
+#ifndef WEBRTC_MODULES_VIDEO_CODING_CODECS_H264_H264_ENCODER_IMPL_H_
+#define WEBRTC_MODULES_VIDEO_CODING_CODECS_H264_H264_ENCODER_IMPL_H_
+
+#include "webrtc/modules/video_coding/codecs/h264/include/h264.h"
+
+#include <vector>
+
+#include "webrtc/base/scoped_ptr.h"
+
+class ISVCEncoder;
+
+namespace webrtc {
+
+class H264EncoderImpl : public H264Encoder {
+ public:
+ H264EncoderImpl();
+ ~H264EncoderImpl() override;
+
+ // |number_of_cores| and |max_payload_size| are ignored.
+ // The following members of |codec_settings| are used. The rest are ignored.
+ // - codecType (must be kVideoCodecH264)
+ // - targetBitrate
+ // - maxFramerate
+ // - width
+ // - height
+ int32_t InitEncode(const VideoCodec* codec_settings,
+ int32_t /*number_of_cores*/,
+ size_t /*max_payload_size*/) override;
+ int32_t Release() override;
+
+ int32_t RegisterEncodeCompleteCallback(
+ EncodedImageCallback* callback) override;
+ int32_t SetRates(uint32_t bitrate, uint32_t framerate) override;
+
+ // The result of encoding - an EncodedImage and RTPFragmentationHeader - are
+ // passed to the encode complete callback.
+ int32_t Encode(const VideoFrame& frame,
+ const CodecSpecificInfo* codec_specific_info,
+ const std::vector<FrameType>* frame_types) override;
+
+ // Unsupported / Do nothing.
+ int32_t SetChannelParameters(uint32_t packet_loss, int64_t rtt) override;
+ int32_t SetPeriodicKeyFrames(bool enable) override;
+ void OnDroppedFrame() override;
+
+ private:
+ bool IsInitialized() const;
+
+ ISVCEncoder* openh264_encoder_;
+ VideoCodec codec_settings_;
+
+ EncodedImage encoded_image_;
+ rtc::scoped_ptr<uint8_t[]> encoded_image_buffer_;
hbos 2016/01/07 19:41:15 (Ensures new[] is matched with delete[] and not de
+ EncodedImageCallback* encoded_image_callback_;
+};
+
+} // namespace webrtc
+
+#endif // WEBRTC_MODULES_VIDEO_CODING_CODECS_H264_H264_ENCODER_IMPL_H_

Powered by Google App Engine
This is Rietveld 408576698