Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Unified Diff: webrtc/video/end_to_end_tests.cc

Issue 1306813009: H.264 video codec support using OpenH264/FFmpeg (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: (Alphabetical sorting in common_video.gyp deps) Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/test/encoder_settings.cc ('k') | webrtc/video/video_quality_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/video/end_to_end_tests.cc
diff --git a/webrtc/video/end_to_end_tests.cc b/webrtc/video/end_to_end_tests.cc
index d036474c13d3888e606f38dc0034990ff61061ae..6201e92220f0291085451ee6bb46bdb98ae8d9fd 100644
--- a/webrtc/video/end_to_end_tests.cc
+++ b/webrtc/video/end_to_end_tests.cc
@@ -23,6 +23,7 @@
#include "webrtc/modules/rtp_rtcp/include/rtp_rtcp.h"
#include "webrtc/modules/rtp_rtcp/source/byte_io.h"
#include "webrtc/modules/rtp_rtcp/source/rtcp_utility.h"
+#include "webrtc/modules/video_coding/codecs/h264/include/h264.h"
#include "webrtc/modules/video_coding/codecs/vp8/include/vp8.h"
#include "webrtc/modules/video_coding/codecs/vp9/include/vp9.h"
#include "webrtc/modules/video_coding/include/video_coding_defines.h"
@@ -286,12 +287,15 @@ TEST_F(EndToEndTest, SendsAndReceivesVP9) {
RunBaseTest(&test);
}
+#if defined(WEBRTC_END_TO_END_H264_TESTS)
+
TEST_F(EndToEndTest, SendsAndReceivesH264) {
class H264Observer : public test::EndToEndTest, public VideoRenderer {
public:
H264Observer()
: EndToEndTest(2 * kDefaultTimeoutMs),
- fake_encoder_(Clock::GetRealTimeClock()),
+ encoder_(VideoEncoder::Create(VideoEncoder::kH264)),
+ decoder_(H264Decoder::Create()),
frame_counter_(0) {}
void PerformTest() override {
@@ -305,9 +309,9 @@ TEST_F(EndToEndTest, SendsAndReceivesH264) {
VideoEncoderConfig* encoder_config) override {
send_config->rtp.nack.rtp_history_ms =
(*receive_configs)[0].rtp.nack.rtp_history_ms = kNackRtpHistoryMs;
- send_config->encoder_settings.encoder = &fake_encoder_;
+ send_config->encoder_settings.encoder = encoder_.get();
send_config->encoder_settings.payload_name = "H264";
- send_config->encoder_settings.payload_type = kFakeVideoSendPayloadType;
+ send_config->encoder_settings.payload_type = 126;
encoder_config->streams[0].min_bitrate_bps = 50000;
encoder_config->streams[0].target_bitrate_bps =
encoder_config->streams[0].max_bitrate_bps = 2000000;
@@ -318,7 +322,7 @@ TEST_F(EndToEndTest, SendsAndReceivesH264) {
send_config->encoder_settings.payload_type;
(*receive_configs)[0].decoders[0].payload_name =
send_config->encoder_settings.payload_name;
- (*receive_configs)[0].decoders[0].decoder = &fake_decoder_;
+ (*receive_configs)[0].decoders[0].decoder = decoder_.get();
}
void RenderFrame(const VideoFrame& video_frame,
@@ -331,14 +335,16 @@ TEST_F(EndToEndTest, SendsAndReceivesH264) {
bool IsTextureSupported() const override { return false; }
private:
- test::FakeH264Decoder fake_decoder_;
- test::FakeH264Encoder fake_encoder_;
+ rtc::scoped_ptr<webrtc::VideoEncoder> encoder_;
+ rtc::scoped_ptr<webrtc::VideoDecoder> decoder_;
int frame_counter_;
} test;
RunBaseTest(&test);
}
+#endif // defined(WEBRTC_END_TO_END_H264_TESTS)
+
TEST_F(EndToEndTest, ReceiverUsesLocalSsrc) {
class SyncRtcpObserver : public test::EndToEndTest {
public:
« no previous file with comments | « webrtc/test/encoder_settings.cc ('k') | webrtc/video/video_quality_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698