Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(870)

Issue 1306243013: Remove x11 from libjingle_media (Closed)

Created:
5 years, 3 months ago by phoglund
Modified:
5 years, 3 months ago
Reviewers:
jiayl2
CC:
webrtc-reviews_webrtc.org, kjellander_webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove x11 from libjingle_media This generates incorrect -lX11 with use_x11=0 in our other build system, which causes the standalone libjingle_media target to not build. This patch should fix that. I could remove -lX11 completely, and libjingle still links fine. So does Chrome if I do the corresponding change there, so I think this change is safe to make. BUG=None Committed: https://crrev.com/0ab8ca83650899e50a42a9064aace2aaa5595c52 Cr-Commit-Position: refs/heads/master@{#9869}

Patch Set 1 #

Patch Set 2 : Outright removing X11 for libjingle media (does not appear to be used)" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M talk/libjingle.gyp View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
phoglund
Jiayang: please take a look.
5 years, 3 months ago (2015-09-04 12:28:59 UTC) #2
jiayl2
lgtm
5 years, 3 months ago (2015-09-04 20:37:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306243013/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306243013/20001
5 years, 3 months ago (2015-09-07 07:15:14 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-07 08:14:39 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-07 08:14:45 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0ab8ca83650899e50a42a9064aace2aaa5595c52
Cr-Commit-Position: refs/heads/master@{#9869}

Powered by Google App Engine
This is Rietveld 408576698