talk/app/webrtc/java/android/org/webrtc/VideoRendererGui.java - Issue 1306073003: Android: Remove VideoRenderer.Callbacks.canApplyRotation()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: talk/app/webrtc/java/android/org/webrtc/VideoRendererGui.java

Issue 1306073003: Android: Remove VideoRenderer.Callbacks.canApplyRotation() (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Restore previous test behaviour + remove some dead code Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « talk/app/webrtc/androidtests/src/org/webrtc/VideoCapturerAndroidTest.java ('k') | talk/app/webrtc/java/jni/peerconnection_jni.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: talk/app/webrtc/java/android/org/webrtc/VideoRendererGui.java

diff --git a/talk/app/webrtc/java/android/org/webrtc/VideoRendererGui.java b/talk/app/webrtc/java/android/org/webrtc/VideoRendererGui.java

index a685c397c8f84f0ae879504fe82ad78b4faf65fd..adee98bb5be0f48799139123e8426d93fcb6f80d 100644

--- a/talk/app/webrtc/java/android/org/webrtc/VideoRendererGui.java

+++ b/talk/app/webrtc/java/android/org/webrtc/VideoRendererGui.java

@@ -454,12 +454,6 @@ public class VideoRendererGui implements GLSurfaceView.Renderer {

// Request rendering.

surface.requestRender();

}

- // TODO(guoweis): Remove this once chrome code base is updated.

- @Override

- public boolean canApplyRotation() {

- return true;

- }

}

/** Passes GLSurfaceView to video renderer. */