Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1305303003: Move mock_nonlinear_beamformer to only be a header (Closed)

Created:
5 years, 4 months ago by aluebs-webrtc
Modified:
5 years, 4 months ago
Reviewers:
Andrew MacDonald
CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, tterriberry_mozilla.com, hlundin-webrtc, kwiberg-webrtc, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move mock_nonlinear_beamformer to only be a header

Patch Set 1 #

Patch Set 2 : Remove cc file from gyp file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -24 lines) Patch
M webrtc/modules/audio_processing/beamformer/mock_nonlinear_beamformer.h View 1 chunk +2 lines, -1 line 0 comments Download
D webrtc/modules/audio_processing/beamformer/mock_nonlinear_beamformer.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M webrtc/modules/modules.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
aluebs-webrtc
5 years, 4 months ago (2015-08-21 23:02:41 UTC) #2
Andrew MacDonald
lgtm Looks like you need to remove the cc file from modules.gyp.
5 years, 4 months ago (2015-08-24 17:43:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305303003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305303003/20001
5 years, 4 months ago (2015-08-25 00:45:30 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_msan on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_msan/builds/4292)
5 years, 4 months ago (2015-08-25 01:18:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305303003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305303003/20001
5 years, 4 months ago (2015-08-25 02:05:14 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-25 02:45:50 UTC) #12 
Try jobs failed on following builders:
  mac_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

Powered by Google App Engine
This is Rietveld 408576698