Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1305113002: Clean up some code change (Closed)

Created:
5 years, 4 months ago by guoweis_webrtc
Modified:
5 years, 4 months ago
Reviewers:
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -25 lines) Patch
M talk/app/webrtc/fakemetricsobserver.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/base/network.h View 1 chunk +5 lines, -6 lines 0 comments Download
M webrtc/base/network.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/base/network_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/p2p/base/turnport_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/p2p/client/basicportallocator.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/client/portallocator_unittest.cc View 1 chunk +5 lines, -7 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305113002/1
5 years, 4 months ago (2015-08-21 13:50:42 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305113002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305113002/20001
5 years, 4 months ago (2015-08-21 14:00:40 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_arm64 on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64/builds/3943) win on ...
5 years, 4 months ago (2015-08-21 14:02:10 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305113002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305113002/40001
5 years, 4 months ago (2015-08-21 14:14:48 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-21 15:27:59 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305113002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305113002/40001
5 years, 4 months ago (2015-08-21 16:05:52 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:40001)
5 years, 4 months ago (2015-08-21 16:06:32 UTC) #15
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 16:06:46 UTC) #16
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ea1012b2a41b1b56fe7366792f10390639d82495
Cr-Commit-Position: refs/heads/master@{#9757}

Powered by Google App Engine
This is Rietveld 408576698