Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1305033003: Remove obsolete soundclip.cc/.h files. (Closed)

Created:
5 years, 3 months ago by the sun
Modified:
5 years, 3 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove obsolete soundclip.cc/.h files. BUG= Committed: https://crrev.com/e9ad18b6e1606351b1a4187de52cf5ec6f9975bb Cr-Commit-Position: refs/heads/master@{#9879}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
D talk/session/media/soundclip.h View 1 chunk +0 lines, -2 lines 0 comments Download
D talk/session/media/soundclip.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 18 (8 generated)
the sun
5 years, 3 months ago (2015-09-01 12:39:17 UTC) #2
the sun
Ping...
5 years, 3 months ago (2015-09-07 09:40:57 UTC) #4
tommi
lgtm. sorry, somehow missed this
5 years, 3 months ago (2015-09-07 14:00:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305033003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305033003/20001
5 years, 3 months ago (2015-09-07 14:14:03 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android on tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_arm64_rel on ...
5 years, 3 months ago (2015-09-07 16:14:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305033003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305033003/20001
5 years, 3 months ago (2015-09-07 17:57:33 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
5 years, 3 months ago (2015-09-07 19:57:39 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305033003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305033003/20001
5 years, 3 months ago (2015-09-08 07:43:54 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-08 07:44:58 UTC) #17
commit-bot: I haz the power
5 years, 3 months ago (2015-09-08 07:45:08 UTC) #18
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/e9ad18b6e1606351b1a4187de52cf5ec6f9975bb
Cr-Commit-Position: refs/heads/master@{#9879}

Powered by Google App Engine
This is Rietveld 408576698