Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1304933008: Remove unnecessary fields from VoE SharedData. (Closed)

Created:
5 years, 3 months ago by the sun
Modified:
5 years, 3 months ago
Reviewers:
henrika_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, hlundin-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove unnecessary fields from VoE SharedData. BUG=webrtc:4690 Committed: https://crrev.com/e313e0278315c918d1ae810f79e4b3f176d58659 Cr-Commit-Position: refs/heads/master@{#9882}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -57 lines) Patch
M webrtc/voice_engine/shared_data.h View 2 chunks +0 lines, -7 lines 0 comments Download
M webrtc/voice_engine/shared_data.cc View 1 chunk +1 line, -3 lines 0 comments Download
M webrtc/voice_engine/voe_base_impl.cc View 3 chunks +2 lines, -9 lines 0 comments Download
M webrtc/voice_engine/voe_file_impl.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M webrtc/voice_engine/voe_hardware_impl.cc View 2 chunks +26 lines, -30 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
the sun
5 years, 3 months ago (2015-09-07 13:30:23 UTC) #2
henrika_webrtc
LGTM
5 years, 3 months ago (2015-09-07 14:26:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304933008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304933008/20001
5 years, 3 months ago (2015-09-07 14:38:22 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android on tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_arm64_rel on ...
5 years, 3 months ago (2015-09-07 16:38:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304933008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304933008/20001
5 years, 3 months ago (2015-09-07 17:57:53 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android on tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_rel on ...
5 years, 3 months ago (2015-09-07 19:58:08 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304933008/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304933008/40001
5 years, 3 months ago (2015-09-08 07:46:31 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-08 09:16:08 UTC) #16
commit-bot: I haz the power
5 years, 3 months ago (2015-09-08 09:16:20 UTC) #17
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/e313e0278315c918d1ae810f79e4b3f176d58659
Cr-Commit-Position: refs/heads/master@{#9882}

Powered by Google App Engine
This is Rietveld 408576698