Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 1304063011: Move shared EGL context initialization to a separate function. (Closed)

Created:
5 years, 3 months ago by AlexG
Modified:
5 years, 3 months ago
Reviewers:
wzh
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald, jiayl2
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

- Make shared EGL context used for HW video decoding member of decoder factory class. - Add new Peer connection factory method to initialize shared EGL context. This provides an option to use single peer connection factory in the application and create peer connections from the same factory and reinitialize shared EGL context for video decoding HW acceleration. R=wzh@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/4d2f4d1c6997b4218774cac10527e1cdb88f20d9

Patch Set 1 #

Patch Set 2 : Move EGL context initialization to peer connection #

Patch Set 3 : Move some code. #

Patch Set 4 : Fix typo #

Patch Set 5 : Remove extra line. #

Total comments: 2

Patch Set 6 : Address comment + fix Linux build. #

Messages

Total messages: 18 (8 generated)
AlexG
PTAL
5 years, 3 months ago (2015-09-01 20:19:24 UTC) #2
wzh
lgtm https://codereview.webrtc.org/1304063011/diff/80001/talk/app/webrtc/java/jni/androidmediadecoder_jni.cc File talk/app/webrtc/java/jni/androidmediadecoder_jni.cc (right): https://codereview.webrtc.org/1304063011/diff/80001/talk/app/webrtc/java/jni/androidmediadecoder_jni.cc#newcode238 talk/app/webrtc/java/jni/androidmediadecoder_jni.cc:238: use_surface_ = (render_egl_context_ == NULL) ? false : ...
5 years, 3 months ago (2015-09-01 20:40:45 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304063011/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304063011/80001
5 years, 3 months ago (2015-09-01 20:58:57 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_rel/builds/9170)
5 years, 3 months ago (2015-09-01 21:01:52 UTC) #7
AlexG
https://codereview.webrtc.org/1304063011/diff/80001/talk/app/webrtc/java/jni/androidmediadecoder_jni.cc File talk/app/webrtc/java/jni/androidmediadecoder_jni.cc (right): https://codereview.webrtc.org/1304063011/diff/80001/talk/app/webrtc/java/jni/androidmediadecoder_jni.cc#newcode238 talk/app/webrtc/java/jni/androidmediadecoder_jni.cc:238: use_surface_ = (render_egl_context_ == NULL) ? false : true; ...
5 years, 3 months ago (2015-09-01 21:10:36 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304063011/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304063011/100001
5 years, 3 months ago (2015-09-01 21:11:19 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-01 22:02:52 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304063011/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304063011/100001
5 years, 3 months ago (2015-09-01 22:03:41 UTC) #15
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 3 months ago (2015-09-01 22:03:43 UTC) #17
AlexG
5 years, 3 months ago (2015-09-01 22:04:26 UTC) #18
Message was sent while issue was closed.
Committed patchset #6 (id:100001) manually as
4d2f4d1c6997b4218774cac10527e1cdb88f20d9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698