Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1036)

Unified Diff: webrtc/video/rtc_event_log.h

Issue 1303713002: Keep config events in RtcEventLog even if they are old. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Reviewer comments from ivoc@ Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/video/rtc_event_log.cc » ('j') | webrtc/video/rtc_event_log.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/video/rtc_event_log.h
diff --git a/webrtc/video/rtc_event_log.h b/webrtc/video/rtc_event_log.h
index a6bf2e3d8836d2b7e0ee6f0ca702f56ffc48c366..5cf0a326d6f14881881ff608dcab1c7a66118e62 100644
--- a/webrtc/video/rtc_event_log.h
+++ b/webrtc/video/rtc_event_log.h
@@ -38,6 +38,10 @@ class RtcEventLog {
static rtc::scoped_ptr<RtcEventLog> Create();
+ // Sets the time that events are stored in the internal event buffer
+ // before the user calls StartLogging. The default is 10'000'000 us = 10 s
hlundin-webrtc 2015/08/28 11:16:29 While C++14 allows apostrophe as "thousands separa
terelius 2015/09/17 12:44:08 Though using comma as a separator does not follow
hlundin-webrtc 2015/09/22 09:35:15 Acknowledged.
+ virtual void SetBufferDuration(int64_t recent_log_duration_us) = 0;
+
// Starts logging for the specified duration to the specified file.
// The logging will stop automatically after the specified duration.
// If the file already exists it will be overwritten.
« no previous file with comments | « no previous file | webrtc/video/rtc_event_log.cc » ('j') | webrtc/video/rtc_event_log.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698