webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.h - Issue 1303413003: AudioCodingModuleImpl::Encode: Use a Buffer instead of a stack-allocated array

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.h

Issue 1303413003: AudioCodingModuleImpl::Encode: Use a Buffer instead of a stack-allocated array (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@acm-common-defs

Patch Set: review comment Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_coding/main/acm2/acm_common_defs.h ('k') | webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.h

diff --git a/webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.h b/webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.h

index 842aca076b935f8c015e391753970c2fbcf37a30..fd939012055204f4eba1374f9e60f304c998190f 100644

--- a/webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.h

+++ b/webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.h

@@ -13,6 +13,7 @@

#include <vector>

+#include "webrtc/base/buffer.h"

#include "webrtc/base/scoped_ptr.h"

#include "webrtc/base/thread_annotations.h"

#include "webrtc/common_types.h"

@@ -265,6 +266,7 @@ class AudioCodingModuleImpl final : public AudioCodingModule {

int UpdateUponReceivingCodec(int index);

const rtc::scoped_ptr<CriticalSectionWrapper> acm_crit_sect_;

+ rtc::Buffer encode_buffer_ GUARDED_BY(acm_crit_sect_);

int id_; // TODO(henrik.lundin) Make const.

uint32_t expected_codec_ts_ GUARDED_BY(acm_crit_sect_);

uint32_t expected_in_ts_ GUARDED_BY(acm_crit_sect_);