Android GlUtil: Add helper functions generateTexture/deleteTexture

talk/app/webrtc/java/android/org/webrtc/VideoRendererGui.java

 /*
  * libjingle
  * Copyright 2014 Google Inc.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
  *
  *  1. Redistributions of source code must retain the above copyright notice,
  *     this list of conditions and the following disclaimer.
  *  2. Redistributions in binary form must reproduce the above copyright notice,
@@ skipping 81 matching lines @@
   /**
    * Class used to display stream of YUV420 frames at particular location
    * on a screen. New video frames are sent to display using renderFrame()
    * call.
    */
   private static class YuvImageRenderer implements VideoRenderer.Callbacks {
     // |surface| is synchronized on |this|.
     private GLSurfaceView surface;
     private int id;
     private int[] yuvTextures = { -1, -1, -1 };
     private int oesTexture = -1;

[hbos, 2015/09/02 08:57:55]

Oh, more -1 instead of 0.

These are created and used for drawing. But the textures are never deleted?
Confirm and fix or add a todo.

[magjed_webrtc, 2015/09/02 10:15:39]

Done.

 
     // Render frame queue - accessed by two threads. renderFrame() call does
     // an offer (writing I420Frame to render) and early-returns (recording
     // a dropped frame) if that queue is full. draw() call does a peek(),
     // copies frame to texture and then removes it from a queue using poll().
     private final LinkedBlockingQueue<I420Frame> frameToRenderQueue;
     // Local copy of incoming video frame. Synchronized on |frameToRenderQueue|.
     private I420Frame yuvFrameToRender;
     private I420Frame textureFrameToRender;
     // Type of video frame used for recent frame rendering.
@@ skipping 62 matching lines @@
         yuvFrameToRender = null;
         textureFrameToRender = null;
       }
     }
 
     private void createTextures() {
       Log.d(TAG, "  YuvImageRenderer.createTextures " + id + " on GL thread:" +
           Thread.currentThread().getId());
 
       // Generate 3 texture ids for Y/U/V and place them into |yuvTextures|.
-      GLES20.glGenTextures(3, yuvTextures, 0);
       for (int i = 0; i < 3; i++)  {
-        GLES20.glActiveTexture(GLES20.GL_TEXTURE0 + i);
-        GLES20.glBindTexture(GLES20.GL_TEXTURE_2D, yuvTextures[i]);
-        GLES20.glTexParameterf(GLES20.GL_TEXTURE_2D,
-            GLES20.GL_TEXTURE_MIN_FILTER, GLES20.GL_LINEAR);
-        GLES20.glTexParameterf(GLES20.GL_TEXTURE_2D,
-            GLES20.GL_TEXTURE_MAG_FILTER, GLES20.GL_LINEAR);
-        GLES20.glTexParameterf(GLES20.GL_TEXTURE_2D,
-            GLES20.GL_TEXTURE_WRAP_S, GLES20.GL_CLAMP_TO_EDGE);
-        GLES20.glTexParameterf(GLES20.GL_TEXTURE_2D,
-            GLES20.GL_TEXTURE_WRAP_T, GLES20.GL_CLAMP_TO_EDGE);
+        yuvTextures[i] = GlUtil.generateTexture(GLES20.GL_TEXTURE_2D);
       }
-      GlUtil.checkNoGLES2Error("y/u/v glGenTextures");
     }
 
     private void checkAdjustTextureCoords() {
       synchronized(updateTextureLock) {
         if (!updateTextureProperties) {
           return;
         }
         // Initialize to maximum allowed area. Round to integer coordinates inwards the layout
         // bounding box (ceil left/top and floor right/bottom) to not break constraints.
         displayLayout.set(
@@ skipping 428 matching lines @@
     GLES20.glViewport(0, 0, screenWidth, screenHeight);
     GLES20.glClear(GLES20.GL_COLOR_BUFFER_BIT);
     synchronized (yuvImageRenderers) {
       for (YuvImageRenderer yuvImageRenderer : yuvImageRenderers) {
         yuvImageRenderer.draw(drawer);
       }
     }
   }
 
 }