Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1299543004: Android EglBase: Add helper functions to query the surface size (Closed)

Created:
5 years, 4 months ago by magjed_webrtc
Modified:
5 years, 4 months ago
Reviewers:
AlexG
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Android EglBase: Add helper functions to query the surface size BUG=webrtc:4742 R=glaznev@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/d476b955046aee5d5f750111b567f5ed51bf85b8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M talk/app/webrtc/java/android/org/webrtc/EglBase.java View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
magjed_webrtc
Please take a look. This is a partial reland of https://codereview.webrtc.org/1257043004/.
5 years, 4 months ago (2015-08-17 13:53:51 UTC) #2
AlexG
lgtm
5 years, 4 months ago (2015-08-18 16:57:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1299543004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1299543004/1
5 years, 4 months ago (2015-08-18 19:16:58 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_rel/builds/8894)
5 years, 4 months ago (2015-08-18 19:29:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1299543004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1299543004/1
5 years, 4 months ago (2015-08-19 10:28:06 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_rel/builds/8916)
5 years, 4 months ago (2015-08-19 10:42:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1299543004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1299543004/1
5 years, 4 months ago (2015-08-19 12:52:45 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
5 years, 4 months ago (2015-08-19 14:52:54 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1299543004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1299543004/1
5 years, 4 months ago (2015-08-19 15:17:13 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: android on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
5 years, 4 months ago (2015-08-19 17:17:29 UTC) #19
magjed_webrtc
5 years, 4 months ago (2015-08-20 07:58:50 UTC) #20
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
d476b955046aee5d5f750111b567f5ed51bf85b8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698