Adds RTCCertificate, a reference counted object indirectly owning an SSLCertificate

webrtc/base/rtccertificate.cc

+/*
+ *  Copyright 2015 The WebRTC Project Authors. All rights reserved.
+ *
+ *  Use of this source code is governed by a BSD-style license
+ *  that can be found in the LICENSE file in the root of the source
+ *  tree. An additional intellectual property rights grant can be found
+ *  in the file PATENTS.  All contributing project authors may
+ *  be found in the AUTHORS file in the root of the source tree.
+ */
+
+#include "webrtc/base/rtccertificate.h"
+
+#include "webrtc/base/checks.h"
+#include "webrtc/base/timeutils.h"
+
+namespace rtc {
+
+scoped_refptr<RTCCertificate> RTCCertificate::Create(
+    scoped_ptr<SSLIdentity> identity) {
+  return new RefCountedObject<RTCCertificate>(identity.release());

[tommi (sloooow) - chröme, 2015/08/19 19:42:38]

use Pass()

+}
+
+RTCCertificate::RTCCertificate(SSLIdentity* identity)

[tommi (sloooow) - chröme, 2015/08/19 19:42:38]

change param to scoped_ptr<SSLIdentity> identity

+    : identity_(identity) {

[tommi (sloooow) - chröme, 2015/08/19 19:42:38]

and here do identity_(identity.Pass())

[hbos, 2015/08/20 08:01:39]

Did you see my previous comment?
"Reason for not using scoped_ptr in constructor: The constructor of
RefCountedObject<RTCCertificate> does not realize it has to do .Pass() with
scoped_ptr parameters.
The static Create function substitutes a public constructor."

I don't think what you're asking is possible with scoped_ptr? I tried what you
asked and it didn't compile because the RefCountedObject constructor tries to
call the RTCCertificate constructor without using .Pass().

[tommi (sloooow) - chröme, 2015/08/20 08:49:04]

I probably saw the comment but didn't understand it.  I get it now and the issue
is with this line:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/webrtc...

OK, as is then.

+  DCHECK(identity_);
+}
+
+
+uint64 RTCCertificate::expires_timestamp_ns() const {
+  // TODO(hbos): Update once SSLIdentity/SSLCertificate supports expires field.
+  return 0;
+}
+
+bool RTCCertificate::HasExpired() const {
+  return expires_timestamp_ns() <= TimeNanos();
+}
+
+const SSLCertificate& RTCCertificate::ssl_certificate() const {
+  return identity_->certificate();
+}
+
+}  // namespace rtc