Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(892)

Issue 1298673002: Android: Move common functions from VideoRendererGui to new RendererCommon file (Closed)

Created:
5 years, 4 months ago by magjed_webrtc
Modified:
5 years, 4 months ago
Reviewers:
AlexG
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Android: Move common functions from VideoRendererGui to new RendererCommon file This is primarily done to prepare for a new renderer implementation. BUG=webrtc:4742 R=glaznev@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/ff020c01ca8ad72e513700315ebb6ff16afffd22

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -95 lines) Patch
A talk/app/webrtc/java/android/org/webrtc/RendererCommon.java View 1 chunk +139 lines, -0 lines 0 comments Download
M talk/app/webrtc/java/android/org/webrtc/VideoRendererGui.java View 13 chunks +14 lines, -93 lines 0 comments Download
M talk/libjingle.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/examples/androidapp/src/org/appspot/apprtc/CallActivity.java View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/examples/androidapp/src/org/appspot/apprtc/CallFragment.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
magjed_webrtc
Please take a look. This is a partial reland of https://codereview.webrtc.org/1257043004/ plus I also moved ...
5 years, 4 months ago (2015-08-17 13:54:29 UTC) #2
AlexG
lgtm
5 years, 4 months ago (2015-08-18 16:56:20 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1298673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1298673002/1
5 years, 4 months ago (2015-08-20 09:49:32 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
5 years, 4 months ago (2015-08-20 11:49:46 UTC) #7
magjed_webrtc
5 years, 4 months ago (2015-08-20 12:03:22 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ff020c01ca8ad72e513700315ebb6ff16afffd22 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698