webrtc/test/rtp_file_writer.cc - Issue 1297653002: Tool to convert RtcEventLog files to RtpDump format.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/test/rtp_file_writer.cc

Issue 1297653002: Tool to convert RtcEventLog files to RtpDump format. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Inverted the command line flags and fixed bug when converting RTCP packets. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/test/rtp_file_writer.cc

diff --git a/webrtc/test/rtp_file_writer.cc b/webrtc/test/rtp_file_writer.cc

index 4acaa27815d325342681dfa1091049132b2d9111..d1761b157468b9faf797331e04b84044adbd042e 100644

--- a/webrtc/test/rtp_file_writer.cc

+++ b/webrtc/test/rtp_file_writer.cc

@@ -40,7 +40,6 @@ class RtpDumpWriter : public RtpFileWriter {

bool WritePacket(const RtpPacket* packet) override {

uint16_t len = static_cast<uint16_t>(packet->length + kPacketHeaderSize);

- CHECK_GE(packet->original_length, packet->length);

uint16_t plen = static_cast<uint16_t>(packet->original_length);

uint32_t offset = packet->time_ms;

CHECK(WriteUint16(len));

« no previous file with comments | « no previous file | webrtc/video/rtc_event_log2rtp_dump.cc » ('j') | webrtc/video/rtc_event_log2rtp_dump.cc » ('J')