Tool to convert RtcEventLog files to RtpDump format.

webrtc/webrtc.gyp

 # Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 {
   'conditions': [
     ['include_tests==1', {
@@ skipping 11 matching lines @@
           # This target should only be built if enable_protobuf is defined
           'target_name': 'rtc_event_log_proto',
           'type': 'static_library',
           'sources': ['video/rtc_event_log.proto',],
           'variables': {
             'proto_in_dir': 'video',
             'proto_out_dir': 'webrtc/video',
           },
         'includes': ['build/protoc.gypi'],
         },
+        {
+          'target_name': 'rtc_event_log2rtp_dump',

[hlundin-webrtc, 2015/08/17 11:14:34]

I'm not sure that webrtc.gyp is the right place for this target. Since the
source file is in webrtc/video, is there any gyp(i) file closer to the source?

[terelius, 2015/08/17 11:39:06]

Yes, there is a webrtc_video.gypi, but it just contains one big list of source
files. It does not contain any targets or build rules, which is why we placed
the rtc_event_log target in webrtc.gyp.

I agree that creating a large number of (not really video-related) files in
webrtc/video and corresponding targets in webrtc.gyp is bad. That's why I
suggested moving the rtc_event_log stuff to it's own folder, but I think that
might be better to do in a separate CL. Do you agree?

[ivoc, 2015/08/21 14:30:57]

For now I think webrtc.gyp is the right place, since that is also where the
rtc_event_log and rtc_event_log_proto targets are defined. 
I agree that moving the event log files to a separate folder (and separate gyp
file) makes sense, but it should indeed be in a seperate CL. 

+          'type': 'executable',
+          'sources': ['video/rtc_event_log2rtp_dump.cc',],
+          'dependencies': [
+            '<(DEPTH)/third_party/gflags/gflags.gyp:gflags',
+            'rtc_event_log',
+            'rtc_event_log_proto',

[terelius, 2015/08/17 08:19:48]

Do we need to explicitly depend on both rtc_event_log and rtc_event_log_proto?
rtc_event_log already depends on rtc_event_log_proto (at least assuming that
protobuf is enabled).

[ivoc, 2015/08/21 14:30:57]

I'm afraid it is needed here, because the log-parsing functionality is used. The
path to the automatically generated protobuf headers is set in
rtc_event_log_proto.

+            'test/test.gyp:rtp_test_utils'
+          ],
+        }
       ],
     }],
   ],
   'includes': [
     'build/common.gypi',
     'video/webrtc_video.gypi',
   ],
   'variables': {
     'webrtc_all_dependencies': [
       'base/base.gyp:*',
@@ skipping 82 matching lines @@
           ],
           'defines': [
             'ENABLE_RTC_EVENT_LOG',
           ],
         }],
       ],
     },
 
   ],
 }