Let max default bitrate depend on resolution when configuring one video stream (was previously alwa…

Let max default bitrate depend on resolution when configuring one video stream (was previously always 2Mbps).

Is now set to:
<= 320x240: 600kbps
<= 640x480: 1.7Mbps
<= 960x540: 2Mbps
>  960x540: 2.5Mbps

For QVGA and VGA, the qp was around 10 at the selected thresholds when running some tests. The change in qp declined above the selected bitrates.

BUG=
R=mflodman@webrtc.org, pbos@webrtc.org, stefan@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/1c7d48d431e098ba42fa6bd9f1cfe69a703edee5

[åsapersson, 2015-08-19 12:46:15]

Patchset #2 (id:20001) has been deleted

[åsapersson, 2015-08-19 12:55:14]

Patchset #2 (id:40001) has been deleted

[åsapersson, 2015-08-19 12:55:18]

Patchset #1 (id:1) has been deleted

[åsapersson, 2015-08-19 14:49:58]

asapersson@webrtc.org changed reviewers:
+ mflodman@webrtc.org

[åsapersson, 2015-08-24 08:47:46]

asapersson@webrtc.org changed reviewers:
+ pbos@webrtc.org

[åsapersson, 2015-09-03 07:10:13]

asapersson@webrtc.org changed reviewers:
+ stefan@webrtc.org

[mflodman, 2015-09-03 13:20:58]

LG, but can you explain the reason behind these exact numbers?

[pbos-webrtc, 2015-09-03 13:25:00]

On 2015/09/03 13:20:58, mflodman wrote:
> LG, but can you explain the reason behind these exact numbers?

Please put that in a comment as well. :)

[åsapersson, 2015-09-03 13:28:54]

On 2015/09/03 13:20:58, mflodman wrote:
> LG, but can you explain the reason behind these exact numbers?

For QVGA and VGA, at these bitrates the qp was around 10 in some tests i ran.

[stefan-webrtc, 2015-09-03 13:32:47]

On 2015/09/03 13:28:54, åsapersson wrote:
> On 2015/09/03 13:20:58, mflodman wrote:
> > LG, but can you explain the reason behind these exact numbers?
> 
> For QVGA and VGA, at these bitrates the qp was around 10 in some tests i ran.

Also worth noting that the change in QP declined with bitrates above the ones
selected.

[stefan-webrtc, 2015-09-07 10:02:56]

lgtm

[pbos-webrtc, 2015-09-07 10:18:25]

lgtm

https://codereview.webrtc.org/1297373003/diff/140001/talk/media/webrtc/webrtc...
File talk/media/webrtc/webrtcvideoengine2.cc (right):

https://codereview.webrtc.org/1297373003/diff/140001/talk/media/webrtc/webrtc...
talk/media/webrtc/webrtcvideoengine2.cc:312: // The selected thresholds for QVGA
and VGA corresponded to a qp around 10.
s/qp/QP/

[åsapersson, 2015-09-07 10:22:17]

https://codereview.webrtc.org/1297373003/diff/140001/talk/media/webrtc/webrtc...
File talk/media/webrtc/webrtcvideoengine2.cc (right):

https://codereview.webrtc.org/1297373003/diff/140001/talk/media/webrtc/webrtc...
talk/media/webrtc/webrtcvideoengine2.cc:312: // The selected thresholds for QVGA
and VGA corresponded to a qp around 10.
On 2015/09/07 10:18:25, pbos-webrtc wrote:
> s/qp/QP/

Done.

[mflodman, 2015-09-08 05:56:15]

LGTM

[åsapersson, 2015-09-08 07:22:00]

Committed patchset #7 (id:180001) manually as
1c7d48d431e098ba42fa6bd9f1cfe69a703edee5 (presubmit successful).