Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 1296793004: Fixing Pylint errors for plot_dynamics.py (Closed)

Created:
5 years, 4 months ago by ivica
Modified:
5 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, stefan-webrtc, mflodman, sprang_webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Adding save_figure flag. Changing jpg to png. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -23 lines) Patch
M webrtc/modules/remote_bitrate_estimator/test/plot_dynamics.py View 1 6 chunks +27 lines, -23 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
ivica
Pylint was complaining in another cl for this file even though it hasn't been changed ...
5 years, 4 months ago (2015-08-20 16:17:54 UTC) #2
ivica
Adding pbos since stefan is on vacation.
5 years, 4 months ago (2015-08-25 08:19:57 UTC) #4
pbos-webrtc
https://codereview.webrtc.org/1296793004/diff/1/webrtc/modules/remote_bitrate_estimator/test/plot_dynamics.py File webrtc/modules/remote_bitrate_estimator/test/plot_dynamics.py (right): https://codereview.webrtc.org/1296793004/diff/1/webrtc/modules/remote_bitrate_estimator/test/plot_dynamics.py#newcode139 webrtc/modules/remote_bitrate_estimator/test/plot_dynamics.py:139: # if line.startswith("[ RUN ]"): Don't comment these out, ...
5 years, 4 months ago (2015-08-25 08:43:55 UTC) #5
pbos-webrtc
lgtm
5 years, 4 months ago (2015-08-25 08:56:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1296793004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1296793004/20001
5 years, 4 months ago (2015-08-25 08:57:58 UTC) #8
ivica
5 years, 4 months ago (2015-08-25 09:01:49 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
87a8fbbf3785e3338134fd23aab1cc28074971d9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698