Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1602)

Unified Diff: webrtc/modules/audio_coding/neteq/interface/neteq.h

Issue 1296633002: NetEq/ACM: Refactor how packet waiting times are calculated (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Rebasing Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_coding/neteq/interface/neteq.h
diff --git a/webrtc/modules/audio_coding/neteq/interface/neteq.h b/webrtc/modules/audio_coding/neteq/interface/neteq.h
index 865a8b38edbabac454ada061a16f499059125d13..e2ea00debbe35226ab3a78f0e95a843827fba850 100644
--- a/webrtc/modules/audio_coding/neteq/interface/neteq.h
+++ b/webrtc/modules/audio_coding/neteq/interface/neteq.h
@@ -14,7 +14,6 @@
#include <string.h> // Provide access to size_t.
#include <string>
-#include <vector>
#include "webrtc/base/constructormagic.h"
#include "webrtc/common_types.h"
@@ -46,6 +45,12 @@ struct NetEqNetworkStatistics {
int32_t clockdrift_ppm; // Average clock-drift in parts-per-million
// (positive or negative).
size_t added_zero_samples; // Number of zero samples added in "off" mode.
+ // Statistics for packet waiting times, i.e., the time between a packet
+ // arrives until it is decoded.
+ int mean_waiting_time_ms;
+ int median_waiting_time_ms;
+ int min_waiting_time_ms;
+ int max_waiting_time_ms;
};
enum NetEqOutputType {
@@ -227,11 +232,6 @@ class NetEq {
// after the call.
virtual int NetworkStatistics(NetEqNetworkStatistics* stats) = 0;
- // Writes the last packet waiting times (in ms) to |waiting_times|. The number
- // of values written is no more than 100, but may be smaller if the interface
- // is polled again before 100 packets has arrived.
- virtual void WaitingTimes(std::vector<int>* waiting_times) = 0;
-
// Writes the current RTCP statistics to |stats|. The statistics are reset
// and a new report period is started with the call.
virtual void GetRtcpStatistics(RtcpStatistics* stats) = 0;

Powered by Google App Engine
This is Rietveld 408576698