Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 1296513002: Remove WebRtcIsac_Highpass_float(). (Closed)

Created:
5 years, 4 months ago by Peter Kasting
Modified:
5 years, 4 months ago
Reviewers:
minyue-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, hlundin-webrtc, kwiberg-webrtc, tlegrand-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove WebRtcIsac_Highpass_float(). This function is unreferenced and not even declared in a header file. Split from https://codereview.webrtc.org/1228793004/ . BUG=none TEST=none Committed: https://crrev.com/805d8fb6eba5dfe4a1d4a875769d2f355683e21d Cr-Commit-Position: refs/heads/master@{#9716}

Patch Set 1 #

Patch Set 2 : Fix build failure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M webrtc/modules/audio_coding/codecs/isac/main/source/filter_functions.c View 1 2 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Peter Kasting
I carved this off from the larger CL, since you wanted me to avoid removing ...
5 years, 4 months ago (2015-08-14 00:08:05 UTC) #2
minyue-webrtc
On 2015/08/14 00:08:05, Peter Kasting wrote: > I carved this off from the larger CL, ...
5 years, 4 months ago (2015-08-14 08:11:57 UTC) #3
Peter Kasting
On 2015/08/14 08:11:57, minyue-webrtc wrote: > maybe rename the title to Remove WebRtcIsac_Highpass_float(). Done, and ...
5 years, 4 months ago (2015-08-14 19:36:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1296513002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1296513002/20001
5 years, 4 months ago (2015-08-14 19:37:08 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-14 19:38:06 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-14 19:38:16 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/805d8fb6eba5dfe4a1d4a875769d2f355683e21d
Cr-Commit-Position: refs/heads/master@{#9716}

Powered by Google App Engine
This is Rietveld 408576698