Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1296163004: Use RtcpPacket to send TMMBR in RtcpSender (Closed)

Created:
5 years, 4 months ago by sprang_webrtc
Modified:
5 years, 4 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use RtcpPacket to send TMMBR in RtcpSender BUG=webrtc:2450 Committed: https://crrev.com/81a3e60c639b5b05486acd1fb84e376271e50012 Cr-Commit-Position: refs/heads/master@{#9755}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -39 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtcp_sender.cc View 1 chunk +8 lines, -39 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
sprang_webrtc
5 years, 4 months ago (2015-08-18 10:01:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1296163004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1296163004/1
5 years, 4 months ago (2015-08-18 10:01:47 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 4 months ago (2015-08-18 10:01:48 UTC) #6
åsapersson
lgtm
5 years, 4 months ago (2015-08-19 09:07:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1296163004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1296163004/1
5 years, 4 months ago (2015-08-19 13:48:01 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
5 years, 4 months ago (2015-08-19 15:48:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1296163004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1296163004/1
5 years, 4 months ago (2015-08-21 11:24:59 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-21 12:30:15 UTC) #14
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 12:30:37 UTC) #15
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/81a3e60c639b5b05486acd1fb84e376271e50012
Cr-Commit-Position: refs/heads/master@{#9755}

Powered by Google App Engine
This is Rietveld 408576698