Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 1296113002: Remove cricket::VideoProcessor and AddVideoProcessor() functionality (Closed)

Created:
5 years, 4 months ago by magjed_webrtc
Modified:
5 years, 4 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove cricket::VideoProcessor and AddVideoProcessor() functionality This functionality is not used internally in WebRTC. Also, it's not safe, because the frame is supposed to be read-only, and it will likely not work for texture frames. R=pthatcher@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/c232096eba8aa96b7dcbf52a1e956713c07e9972

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -312 lines) Patch
M talk/libjingle.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M talk/media/base/capturemanager.h View 3 chunks +1 line, -9 lines 0 comments Download
M talk/media/base/capturemanager.cc View 2 chunks +0 lines, -26 lines 0 comments Download
M talk/media/base/capturemanager_unittest.cc View 3 chunks +0 lines, -29 lines 0 comments Download
M talk/media/base/capturerenderadapter.cc View 1 chunk +0 lines, -1 line 0 comments Download
M talk/media/base/fakemediaengine.h View 2 chunks +1 line, -2 lines 0 comments Download
M talk/media/base/fakemediaprocessor.h View 2 chunks +2 lines, -20 lines 0 comments Download
M talk/media/base/mediaengine.h View 1 chunk +0 lines, -1 line 0 comments Download
M talk/media/base/videocapturer.h View 7 chunks +2 lines, -26 lines 0 comments Download
M talk/media/base/videocapturer.cc View 9 chunks +0 lines, -44 lines 0 comments Download
M talk/media/base/videocapturer_unittest.cc View 3 chunks +0 lines, -62 lines 0 comments Download
D talk/media/base/videoprocessor.h View 1 chunk +0 lines, -50 lines 0 comments Download
M talk/session/media/channelmanager.h View 3 chunks +1 line, -13 lines 0 comments Download
M talk/session/media/channelmanager.cc View 1 chunk +0 lines, -28 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
magjed_webrtc
Please take a look. This is some other code I don't think is used. I ...
5 years, 4 months ago (2015-08-20 13:25:17 UTC) #2
pthatcher1
lgtm, nice removal By the way, you could also remove RegisterVoiceProcessor: https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libjingle/source/talk/media/base/mediaengine.h&sq=package:chromium&type=cs&rcl=1440099541&l=244
5 years, 4 months ago (2015-08-20 23:29:29 UTC) #3
magjed_webrtc
5 years, 4 months ago (2015-08-21 09:40:48 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c232096eba8aa96b7dcbf52a1e956713c07e9972 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698