Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1292293002: Add Android VideoRendererGui events. (Closed)

Created:
5 years, 4 months ago by AlexG
Modified:
5 years, 4 months ago
Reviewers:
wzh
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald, jiayl2, magjed_webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add Android VideoRendererGui events. Add events to Android VideoRendererGui implementation to optionally report first rendered frame and video frame dimension changes. R=wzh@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/55e9a7dc4ba922599d4fbcf25f13629ba210fc64

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Patch Set 3 : Fix incorrect keyword sequence. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -0 lines) Patch
M talk/app/webrtc/java/android/org/webrtc/VideoRendererGui.java View 1 2 5 chunks +39 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
AlexG
5 years, 4 months ago (2015-08-14 00:39:54 UTC) #2
AlexG
PTAL
5 years, 4 months ago (2015-08-14 00:40:26 UTC) #3
wzh
lgtm https://codereview.webrtc.org/1292293002/diff/1/talk/app/webrtc/java/android/org/webrtc/VideoRendererGui.java File talk/app/webrtc/java/android/org/webrtc/VideoRendererGui.java (right): https://codereview.webrtc.org/1292293002/diff/1/talk/app/webrtc/java/android/org/webrtc/VideoRendererGui.java#newcode404 talk/app/webrtc/java/android/org/webrtc/VideoRendererGui.java:404: ". Reporting frame resolution changed to " + ...
5 years, 4 months ago (2015-08-14 16:53:28 UTC) #4
AlexG
https://codereview.webrtc.org/1292293002/diff/1/talk/app/webrtc/java/android/org/webrtc/VideoRendererGui.java File talk/app/webrtc/java/android/org/webrtc/VideoRendererGui.java (right): https://codereview.webrtc.org/1292293002/diff/1/talk/app/webrtc/java/android/org/webrtc/VideoRendererGui.java#newcode404 talk/app/webrtc/java/android/org/webrtc/VideoRendererGui.java:404: ". Reporting frame resolution changed to " + videoWidth ...
5 years, 4 months ago (2015-08-14 18:28:12 UTC) #5
AlexG
5 years, 4 months ago (2015-08-14 18:46:48 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
55e9a7dc4ba922599d4fbcf25f13629ba210fc64 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698