Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1817)

Unified Diff: talk/media/webrtc/webrtcvideoengine2.h

Issue 1291763003: Don't do reconfiguration if recv codec order/preference changes (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: missed a line Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | talk/media/webrtc/webrtcvideoengine2.cc » ('j') | talk/media/webrtc/webrtcvideoengine2.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: talk/media/webrtc/webrtcvideoengine2.h
diff --git a/talk/media/webrtc/webrtcvideoengine2.h b/talk/media/webrtc/webrtcvideoengine2.h
index 9d04526f4b33d305512c78c0960908876c1093eb..6e1f12c4271c37d7ed5d214de0ba9bec9ae4df0e 100644
--- a/talk/media/webrtc/webrtcvideoengine2.h
+++ b/talk/media/webrtc/webrtcvideoengine2.h
@@ -261,6 +261,9 @@ class WebRtcVideoChannel2 : public rtc::MessageHandler,
int rtx_payload_type;
};
+ static std::string CodecSettingsVectorToString(
+ const std::vector<VideoCodecSettings>& codecs);
+
// Wrapper for the sender part, this is where the capturer is connected and
// frames are then converted from cricket frames to webrtc frames.
class WebRtcVideoSendStream : public sigslot::has_slots<> {
@@ -494,6 +497,8 @@ class WebRtcVideoChannel2 : public rtc::MessageHandler,
const std::vector<VideoCodec>& codecs);
std::vector<VideoCodecSettings> FilterSupportedCodecs(
const std::vector<VideoCodecSettings>& mapped_codecs) const;
+ static bool ReceiveCodecsHaveChanged(std::vector<VideoCodecSettings> before,
tommi 2015/08/22 21:44:04 shouldn't these be passed by const ref instead of
pthatcher1 2015/08/24 16:19:11 They get sorted immediately after being passed in,
+ std::vector<VideoCodecSettings> after);
void FillSenderStats(VideoMediaInfo* info);
void FillReceiverStats(VideoMediaInfo* info);
« no previous file with comments | « no previous file | talk/media/webrtc/webrtcvideoengine2.cc » ('j') | talk/media/webrtc/webrtcvideoengine2.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698