Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Unified Diff: talk/media/webrtc/webrtcvideoengine2_unittest.cc

Issue 1291763003: Don't do reconfiguration if recv codec order/preference changes (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Adding unit test Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: talk/media/webrtc/webrtcvideoengine2_unittest.cc
diff --git a/talk/media/webrtc/webrtcvideoengine2_unittest.cc b/talk/media/webrtc/webrtcvideoengine2_unittest.cc
index 5c4fd6265e4f31ab54f2e181beb321cd041abfa4..ce02d9af3ce4afbd5499239ca9a4a23becfdb5fc 100644
--- a/talk/media/webrtc/webrtcvideoengine2_unittest.cc
+++ b/talk/media/webrtc/webrtcvideoengine2_unittest.cc
@@ -2183,6 +2183,26 @@ TEST_F(WebRtcVideoChannel2Test,
EXPECT_TRUE(channel_->SetRecvCodecs(codecs));
}
+// Test that setting the same codecs but with a different order and preference
+// doesn't result in the stream being recreated.
+TEST_F(WebRtcVideoChannel2Test,
+ SetRecvCodecsDifferentOrderAndPreferenceDoesntRecreateStream) {
+ std::vector<VideoCodec> codecs1;
+ codecs1.push_back(kVp8Codec);
+ codecs1.push_back(kRedCodec);
+ EXPECT_TRUE(channel_->SetRecvCodecs(codecs1));
+
+ AddRecvStream(cricket::StreamParams::CreateLegacy(123));
+ EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
+
+ std::vector<VideoCodec> codecs2;
+ codecs2.push_back(kRedCodec);
+ codecs2.push_back(kVp8Codec);
+ codecs2[1].preference += 1;
+ EXPECT_TRUE(channel_->SetRecvCodecs(codecs2));
+ EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
+}
+
TEST_F(WebRtcVideoChannel2Test, SendStreamNotSendingByDefault) {
EXPECT_FALSE(AddSendStream()->IsSending());
}
« talk/media/webrtc/webrtcvideoengine2.cc ('K') | « talk/media/webrtc/webrtcvideoengine2.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698