Don't do reconfiguration if recv codec order/preference changes

talk/media/webrtc/webrtcvideoengine2_unittest.cc

 /*
  * libjingle
  * Copyright 2004 Google Inc.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
  *
  *  1. Redistributions of source code must retain the above copyright notice,
  *     this list of conditions and the following disclaimer.
  *  2. Redistributions in binary form must reproduce the above copyright notice,
@@ skipping 2165 matching lines @@
 
 TEST_F(WebRtcVideoChannel2Test,
        SetRecvCodecsAcceptSameCodecOnMultiplePayloadTypes) {
   std::vector<VideoCodec> codecs;
   codecs.push_back(kVp8Codec);
   codecs.push_back(kVp8Codec);
   codecs[1].id += 1;
   EXPECT_TRUE(channel_->SetRecvCodecs(codecs));
 }
 
+// Test that setting the same codecs but with a different order and preference
+// doesn't result in the stream being recreated.
+TEST_F(WebRtcVideoChannel2Test,
+       SetRecvCodecsDifferentOrderAndPreferenceDoesntRecreateStream) {
+  std::vector<VideoCodec> codecs1;
+  codecs1.push_back(kVp8Codec);
+  codecs1.push_back(kRedCodec);
+  EXPECT_TRUE(channel_->SetRecvCodecs(codecs1));
+
+  AddRecvStream(cricket::StreamParams::CreateLegacy(123));
+  EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
+
+  std::vector<VideoCodec> codecs2;
+  codecs2.push_back(kRedCodec);
+  codecs2.push_back(kVp8Codec);
+  codecs2[1].preference += 1;
+  EXPECT_TRUE(channel_->SetRecvCodecs(codecs2));
+  EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
+}
+
 TEST_F(WebRtcVideoChannel2Test, SendStreamNotSendingByDefault) {
   EXPECT_FALSE(AddSendStream()->IsSending());
 }
 
 TEST_F(WebRtcVideoChannel2Test, ReceiveStreamReceivingByDefault) {
   EXPECT_TRUE(AddRecvStream()->IsReceiving());
 }
 
 TEST_F(WebRtcVideoChannel2Test, SetSend) {
   FakeVideoSendStream* stream = AddSendStream();
@@ skipping 926 matching lines @@
 // Ensures that the correct settings are applied to the codec when two temporal
 // layer screencasting is enabled, and that the correct simulcast settings are
 // reapplied when disabling screencasting.
 TEST_F(WebRtcVideoChannel2SimulcastTest,
        DISABLED_TwoTemporalLayerScreencastSettings) {
   // TODO(pbos): Implement.
   FAIL() << "Not implemented.";
 }
 
 }  // namespace cricket