Disallow simulcast for non-vp8.

Disallow simulcast for H.264.

BUG=

Committed: https://crrev.com/fdac516510a2bd5d57b0786fbd49e2a6b9aeed2f
Cr-Commit-Position: refs/heads/master@{#9795}

[noahric, 2015-08-17 18:57:01]

noahric@chromium.org changed reviewers:
+ pbos@webrtc.org

[noahric, 2015-08-17 18:57:02]

Hey Peter, let me know if this looks ok; this is essentially the behavior from
the old wrve. I'll add a unit test as well, hopefully before you see it :)

[pbos-webrtc, 2015-08-25 14:32:44]

On 2015/08/17 18:57:02, noahric wrote:
> Hey Peter, let me know if this looks ok; this is essentially the behavior from
> the old wrve. I'll add a unit test as well, hopefully before you see it :)

Why shouldn't we allow it for non-VP8? HW encoders not supporting multi-stream
encoding?

I'd like it plumbed in a more general fashion, such as
EncoderFactory::SupportsSimulcast(VideoCodecType) or something like that.

[noahric, 2015-08-25 15:46:44]

On 2015/08/25 14:32:44, pbos-webrtc wrote:
> On 2015/08/17 18:57:02, noahric wrote:
> > Hey Peter, let me know if this looks ok; this is essentially the behavior
from
> > the old wrve. I'll add a unit test as well, hopefully before you see it :)
> 
> Why shouldn't we allow it for non-VP8? HW encoders not supporting multi-stream
> encoding?
> 
> I'd like it plumbed in a more general fashion, such as
> EncoderFactory::SupportsSimulcast(VideoCodecType) or something like that.

Refactored to IsCodecBlacklistedForSimulcast and changed it to blacklist H.264
instead of whitelist VP8.

[pbos-webrtc, 2015-08-25 16:10:16]

lgtm

[pbos-webrtc, 2015-08-25 16:10:42]

On 2015/08/25 16:10:16, pbos-webrtc wrote:
> lgtm

or you know, ping me when this has tests and I'll take another look

[noahric, 2015-08-26 08:37:01]

Ping, now with tests :)

[pbos-webrtc, 2015-08-26 11:19:11]

lgtm with nit fixed

https://codereview.webrtc.org/1291673006/diff/40001/talk/media/webrtc/webrtcv...
File talk/media/webrtc/webrtcvideoengine2_unittest.cc (right):

https://codereview.webrtc.org/1291673006/diff/40001/talk/media/webrtc/webrtcv...
talk/media/webrtc/webrtcvideoengine2_unittest.cc:667:
EXPECT_LE(encoder->GetCodecSettings().numberOfSimulcastStreams, 1u);
I think _EQ is fine here, if we ever want to make this generate 0u we can just
change the test.

[noahric, 2015-08-26 13:27:36]

https://codereview.webrtc.org/1291673006/diff/40001/talk/media/webrtc/webrtcv...
File talk/media/webrtc/webrtcvideoengine2_unittest.cc (right):

https://codereview.webrtc.org/1291673006/diff/40001/talk/media/webrtc/webrtcv...
talk/media/webrtc/webrtcvideoengine2_unittest.cc:667:
EXPECT_LE(encoder->GetCodecSettings().numberOfSimulcastStreams, 1u);
On 2015/08/26 11:19:11, pbos-webrtc wrote:
> I think _EQ is fine here, if we ever want to make this generate 0u we can just
> change the test.

Done.

[noahric, 2015-08-27 08:38:22]

The CQ bit was checked by noahric@chromium.org

[noahric, 2015-08-27 08:38:23]

The patchset sent to the CQ was uploaded after l-g-t-m from pbos@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1291673006/#ps60001 (title:
"small unit test change (LE->EQ for stream count)")

[commit-bot: I haz the power, 2015-08-27 08:38:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1291673006/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1291673006/60001

[commit-bot: I haz the power, 2015-08-27 08:59:32]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-08-27 08:59:37]

Patchset 4 (id:??) landed as
https://crrev.com/fdac516510a2bd5d57b0786fbd49e2a6b9aeed2f
Cr-Commit-Position: refs/heads/master@{#9795}