talk/media/webrtc/webrtcvideocapturer.h - Issue 1291543006: Update Bind to match its comments and always capture by value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: talk/media/webrtc/webrtcvideocapturer.h

Issue 1291543006: Update Bind to match its comments and always capture by value. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Removed references to std::remove_reference (har har) Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« talk/app/webrtc/java/jni/androidmediaencoder_jni.cc ('K') | « talk/app/webrtc/java/jni/androidmediaencoder_jni.cc ('k') | talk/media/webrtc/webrtcvideocapturer.cc » ('j') | webrtc/base/bind.h.pump » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: talk/media/webrtc/webrtcvideocapturer.h

diff --git a/talk/media/webrtc/webrtcvideocapturer.h b/talk/media/webrtc/webrtcvideocapturer.h

index 66991e097fde473945580eb31528b83105a2ddda..0a99884fe10619f38dceded7194523875dfb69f7 100644

--- a/talk/media/webrtc/webrtcvideocapturer.h

+++ b/talk/media/webrtc/webrtcvideocapturer.h

@@ -92,7 +92,7 @@ class WebRtcVideoCapturer : public VideoCapturer,

// directly from OnIncomingCapturedFrame.

// TODO(tommi): Remove this workaround when we've updated the WebRTC capturers

// to follow the same contract.

- void SignalFrameCapturedOnStartThread(const webrtc::VideoFrame frame);

+ void SignalFrameCapturedOnStartThread(const webrtc::VideoFrame& frame);

rtc::scoped_ptr<WebRtcVcmFactoryInterface> factory_;

webrtc::VideoCaptureModule* module_;