talk/app/webrtc/webrtcsessiondescriptionfactory.cc - Issue 1291363005: Reland "Remove GICE (gone forever!) and PORTALLOCATOR_ENABLE_SHARED_UFRAG (enabled forever)." becau…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: talk/app/webrtc/webrtcsessiondescriptionfactory.cc

Issue 1291363005: Reland "Remove GICE (gone forever!) and PORTALLOCATOR_ENABLE_SHARED_UFRAG (enabled forever)." becau… (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: add comments Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: talk/app/webrtc/webrtcsessiondescriptionfactory.cc

diff --git a/talk/app/webrtc/webrtcsessiondescriptionfactory.cc b/talk/app/webrtc/webrtcsessiondescriptionfactory.cc

index 3dcc0a1a3b7a78a24da249a0f7b9271c07b7e405..6c6981ce5a9987e12f185cc4b351bb105d438bbf 100644

--- a/talk/app/webrtc/webrtcsessiondescriptionfactory.cc

+++ b/talk/app/webrtc/webrtcsessiondescriptionfactory.cc

@@ -148,7 +148,6 @@ WebRtcSessionDescriptionFactory::WebRtcSessionDescriptionFactory(

session_id_(session_id),

data_channel_type_(dct),

identity_request_state_(IDENTITY_NOT_NEEDED) {

- transport_desc_factory_.set_protocol(cricket::ICEPROTO_RFC5245);

session_desc_factory_.set_add_legacy_streams(false);

// SRTP-SDES is disabled if DTLS is on.

SetSdesPolicy(dtls_enabled ? cricket::SEC_DISABLED : cricket::SEC_REQUIRED);

« no previous file with comments | « talk/app/webrtc/webrtcsession_unittest.cc ('k') | talk/session/media/mediasession.h » ('j') | webrtc/p2p/base/p2ptransportchannel_unittest.cc » ('J')