Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1291343002: Use C++11 loops in WebRtcVoiceMediaEngine/Channel. (Closed)

Created:
5 years, 4 months ago by the sun
Modified:
5 years, 3 months ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

- Use C++11 loops in WebRtcVoiceMediaEngine/Channel. - Pull out part of WebRtcVoiceMediaChannel::SetRecvCodecs() into WebRtcVoiceMediaChannel::SetRecvCodecsInternal(). BUG=webrtc:4690 R=pbos@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/af9fb218864b8cb4cccd32280b68dd1b34cb2213

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : merge #

Patch Set 4 : Fix two places where behavior changed slightly. #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -212 lines) Patch
M talk/media/webrtc/webrtcvoiceengine.h View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M talk/media/webrtc/webrtcvoiceengine.cc View 1 2 3 42 chunks +175 lines, -209 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
the sun
5 years, 4 months ago (2015-08-14 13:36:47 UTC) #2
the sun
On 2015/08/14 13:36:47, the sun wrote: Ping! Would be great to have feedback on this ...
5 years, 4 months ago (2015-08-21 09:30:45 UTC) #3
the sun
5 years, 4 months ago (2015-08-25 12:14:59 UTC) #5
pbos-webrtc
On 2015/08/25 12:14:59, the sun wrote: lgtm, please mention the refactoring in the CL description ...
5 years, 4 months ago (2015-08-25 12:23:39 UTC) #6
the sun
5 years, 3 months ago (2015-08-26 08:46:10 UTC) #7
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as
af9fb218864b8cb4cccd32280b68dd1b34cb2213 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698