Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 1291163007: Don't set V bit in flexible mode (Closed)

Created:
5 years, 4 months ago by philipel
Modified:
5 years, 3 months ago
Reviewers:
sprang_webrtc, mflodman
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, tterriberry_mozilla.com, mflodman, perkj_webrtc, andresp
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Don't set V bit in flexible mode BUG=webrtc:4914 Committed: https://crrev.com/7fabd46a89675da596b28bb43c8fd3c561fbe85e Cr-Commit-Position: refs/heads/master@{#9848}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Include in alphabetic order #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -9 lines) Patch
M webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 1 2 5 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
philipel
5 years, 4 months ago (2015-08-18 15:37:34 UTC) #2
philipel
On 2015/08/18 15:37:34, philipel wrote: This CL is dependent on CL 1288363002.
5 years, 4 months ago (2015-08-19 09:54:42 UTC) #3
sprang_webrtc
lgtm +mflodman as owner. ptal
5 years, 4 months ago (2015-08-19 13:40:40 UTC) #5
sprang_webrtc
lgtm +mflodman as owner. ptal
5 years, 4 months ago (2015-08-19 13:40:42 UTC) #6
mflodman
One comment, LGTM with that addressed. https://codereview.webrtc.org/1291163007/diff/1/webrtc/video/video_send_stream_tests.cc File webrtc/video/video_send_stream_tests.cc (right): https://codereview.webrtc.org/1291163007/diff/1/webrtc/video/video_send_stream_tests.cc#newcode21 webrtc/video/video_send_stream_tests.cc:21: #include "webrtc/modules/video_coding/codecs/vp9/include/vp9.h" Alphabetic ...
5 years, 3 months ago (2015-08-31 14:09:06 UTC) #7
philipel
https://codereview.webrtc.org/1291163007/diff/1/webrtc/video/video_send_stream_tests.cc File webrtc/video/video_send_stream_tests.cc (right): https://codereview.webrtc.org/1291163007/diff/1/webrtc/video/video_send_stream_tests.cc#newcode21 webrtc/video/video_send_stream_tests.cc:21: #include "webrtc/modules/video_coding/codecs/vp9/include/vp9.h" On 2015/08/31 14:09:06, mflodman wrote: > Alphabetic ...
5 years, 3 months ago (2015-09-01 12:26:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1291163007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1291163007/20001
5 years, 3 months ago (2015-09-03 08:53:45 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_gn_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_gn_rel/builds/5407) linux on tryserver.webrtc (JOB_FAILED, ...
5 years, 3 months ago (2015-09-03 08:54:30 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1291163007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1291163007/40001
5 years, 3 months ago (2015-09-03 09:25:28 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-03 11:42:35 UTC) #17
commit-bot: I haz the power
5 years, 3 months ago (2015-09-03 11:42:46 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7fabd46a89675da596b28bb43c8fd3c561fbe85e
Cr-Commit-Position: refs/heads/master@{#9848}

Powered by Google App Engine
This is Rietveld 408576698