Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_sender.cc

Issue 1290813008: Add RemoteEstimatorProxy for capturing receive times (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fixed borked Rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_sender.h ('k') | webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/rtp_rtcp/source/rtcp_sender.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_sender.cc b/webrtc/modules/rtp_rtcp/source/rtcp_sender.cc
index eed5cd625f8ceae49b83f1b894ec29663bcc5cf5..6040805d16a4b46ea697c1718b7190103811d899 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_sender.cc
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_sender.cc
@@ -21,6 +21,7 @@
#include "webrtc/common_types.h"
#include "webrtc/modules/rtp_rtcp/source/byte_io.h"
#include "webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h"
+#include "webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h"
#include "webrtc/system_wrappers/interface/critical_section_wrapper.h"
#include "webrtc/system_wrappers/interface/logging.h"
#include "webrtc/system_wrappers/interface/trace_event.h"
@@ -1210,4 +1211,29 @@ bool RTCPSender::AllVolatileFlagsConsumed() const {
return true;
}
+bool RTCPSender::SendFeedbackPacket(const rtcp::TransportFeedback& packet) {
+ CriticalSectionScoped lock(critical_section_transport_.get());
+ if (!cbTransport_)
+ return false;
+
+ class Sender : public rtcp::RtcpPacket::PacketReadyCallback {
+ public:
+ Sender(Transport* transport, int32_t id)
+ : transport_(transport), id_(id), send_failure_(false) {}
+
+ void OnPacketReady(uint8_t* data, size_t length) override {
+ if (transport_->SendRTCPPacket(id_, data, length) <= 0)
+ send_failure_ = true;
+ }
+
+ Transport* const transport_;
+ int32_t id_;
+ bool send_failure_;
+ } sender(cbTransport_, id_);
+
+ uint8_t buffer[IP_PACKET_SIZE];
+ return packet.BuildExternalBuffer(buffer, IP_PACKET_SIZE, &sender) &&
+ !sender.send_failure_;
+}
+
} // namespace webrtc
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_sender.h ('k') | webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698