Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy_unittest.cc

Issue 1290813008: Add RemoteEstimatorProxy for capturing receive times (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Addressed comments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
11 #include "testing/gmock/include/gmock/gmock.h"
12 #include "testing/gtest/include/gtest/gtest.h"
13
14 #include "webrtc/modules/pacing/include/packet_router.h"
15 #include "webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.h"
16 #include "webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h"
17 #include "webrtc/system_wrappers/interface/clock.h"
18
19 using ::testing::_;
20 using ::testing::InSequence;
21 using ::testing::Invoke;
22
23 namespace webrtc {
24
25 class MockPacketRouter : public PacketRouter {
26 public:
27 MOCK_METHOD1(SendFeedback, bool(rtcp::TransportFeedback* packet));
28 };
29
30 class RemoteEstimatorProxyTest : public ::testing::Test {
31 public:
32 RemoteEstimatorProxyTest() : clock_(0), proxy_(&clock_, &router_) {}
33
34 protected:
35 void IncomingPacket(uint16_t seq, int64_t time_ms) {
36 RTPHeader header;
37 header.extension.hasTransportSequenceNumber = true;
38 header.extension.transportSequenceNumber = seq;
39 header.ssrc = kMediaSsrc;
40 proxy_.IncomingPacket(time_ms, kDefaultPacketSize, header, true);
41 }
42
43 void Process() {
44 clock_.AdvanceTimeMilliseconds(
45 RemoteEstimatorProxy::kDefaultProcessIntervalMs);
46 proxy_.Process();
47 }
48
49 SimulatedClock clock_;
50 MockPacketRouter router_;
51 RemoteEstimatorProxy proxy_;
52
53 const size_t kDefaultPacketSize = 100;
54 const uint32_t kMediaSsrc = 456;
55 const uint16_t kBaseSeq = 10;
56 const int64_t kBaseTimeMs = 123;
57 const int64_t kMaxSmallDeltaMs =
58 (rtcp::TransportFeedback::kDeltaScaleFactor * 0xFF) / 1000;
59 };
60
61 TEST_F(RemoteEstimatorProxyTest, SendsSinglePacketFeedback) {
62 IncomingPacket(kBaseSeq, kBaseTimeMs);
63
64 EXPECT_CALL(router_, SendFeedback(_))
65 .Times(1)
66 .WillOnce(Invoke([this](rtcp::TransportFeedback* packet) {
67 packet->Build();
68 EXPECT_EQ(kBaseSeq, packet->GetBaseSequence());
69 EXPECT_EQ(kMediaSsrc, packet->GetMediaSourceSsrc());
70
71 std::vector<rtcp::TransportFeedback::StatusSymbol> status_vec =
72 packet->GetStatusVector();
73 EXPECT_EQ(1u, status_vec.size());
74 EXPECT_EQ(rtcp::TransportFeedback::StatusSymbol::kReceivedSmallDelta,
75 status_vec[0]);
76 std::vector<int64_t> delta_vec = packet->GetReceiveDeltasUs();
77 EXPECT_EQ(1u, delta_vec.size());
78 EXPECT_EQ(kBaseTimeMs, (packet->GetBaseTimeUs() + delta_vec[0]) / 1000);
79 return true;
80 }));
81
82 Process();
83 }
84
85 TEST_F(RemoteEstimatorProxyTest, SendsFeedbackWithVaryingDeltas) {
86 IncomingPacket(kBaseSeq, kBaseTimeMs);
87 IncomingPacket(kBaseSeq + 1, kBaseTimeMs + kMaxSmallDeltaMs);
88 IncomingPacket(kBaseSeq + 2, kBaseTimeMs + (2 * kMaxSmallDeltaMs) + 1);
89
90 EXPECT_CALL(router_, SendFeedback(_))
91 .Times(1)
92 .WillOnce(Invoke([this](rtcp::TransportFeedback* packet) {
93 packet->Build();
94 EXPECT_EQ(kBaseSeq, packet->GetBaseSequence());
95 EXPECT_EQ(kMediaSsrc, packet->GetMediaSourceSsrc());
96
97 std::vector<rtcp::TransportFeedback::StatusSymbol> status_vec =
98 packet->GetStatusVector();
99 EXPECT_EQ(3u, status_vec.size());
100 EXPECT_EQ(rtcp::TransportFeedback::StatusSymbol::kReceivedSmallDelta,
101 status_vec[0]);
102 EXPECT_EQ(rtcp::TransportFeedback::StatusSymbol::kReceivedSmallDelta,
103 status_vec[1]);
104 EXPECT_EQ(rtcp::TransportFeedback::StatusSymbol::kReceivedLargeDelta,
105 status_vec[2]);
106
107 std::vector<int64_t> delta_vec = packet->GetReceiveDeltasUs();
108 EXPECT_EQ(3u, delta_vec.size());
109 EXPECT_EQ(kBaseTimeMs, (packet->GetBaseTimeUs() + delta_vec[0]) / 1000);
110 EXPECT_EQ(kMaxSmallDeltaMs, delta_vec[1] / 1000);
111 EXPECT_EQ(kMaxSmallDeltaMs + 1, delta_vec[2] / 1000);
112 return true;
113 }));
114
115 Process();
116 }
117
118 TEST_F(RemoteEstimatorProxyTest, SendsFragmentedFeedback) {
119 const int64_t kTooLargeDelta =
120 rtcp::TransportFeedback::kDeltaScaleFactor * (1 << 16);
121
122 IncomingPacket(kBaseSeq, kBaseTimeMs);
123 IncomingPacket(kBaseSeq + 1, kBaseTimeMs + kTooLargeDelta);
124
125 InSequence s;
126 EXPECT_CALL(router_, SendFeedback(_))
127 .Times(1)
128 .WillOnce(Invoke([kTooLargeDelta, this](rtcp::TransportFeedback* packet) {
129 packet->Build();
130 EXPECT_EQ(kBaseSeq, packet->GetBaseSequence());
131 EXPECT_EQ(kMediaSsrc, packet->GetMediaSourceSsrc());
132
133 std::vector<rtcp::TransportFeedback::StatusSymbol> status_vec =
134 packet->GetStatusVector();
135 EXPECT_EQ(1u, status_vec.size());
136 EXPECT_EQ(rtcp::TransportFeedback::StatusSymbol::kReceivedSmallDelta,
137 status_vec[0]);
138 std::vector<int64_t> delta_vec = packet->GetReceiveDeltasUs();
139 EXPECT_EQ(1u, delta_vec.size());
140 EXPECT_EQ(kBaseTimeMs, (packet->GetBaseTimeUs() + delta_vec[0]) / 1000);
141 return true;
142 }));
143
144 EXPECT_CALL(router_, SendFeedback(_))
145 .Times(1)
146 .WillOnce(Invoke([kTooLargeDelta, this](rtcp::TransportFeedback* packet) {
147 packet->Build();
148 EXPECT_EQ(kBaseSeq + 1, packet->GetBaseSequence());
149 EXPECT_EQ(kMediaSsrc, packet->GetMediaSourceSsrc());
150
151 std::vector<rtcp::TransportFeedback::StatusSymbol> status_vec =
152 packet->GetStatusVector();
153 EXPECT_EQ(1u, status_vec.size());
154 EXPECT_EQ(rtcp::TransportFeedback::StatusSymbol::kReceivedSmallDelta,
155 status_vec[0]);
156 std::vector<int64_t> delta_vec = packet->GetReceiveDeltasUs();
157 EXPECT_EQ(1u, delta_vec.size());
158 EXPECT_EQ(kBaseTimeMs + kTooLargeDelta,
159 (packet->GetBaseTimeUs() + delta_vec[0]) / 1000);
160 return true;
161 }));
162
163 Process();
164 }
165
166 TEST_F(RemoteEstimatorProxyTest, ResendsTimestampsOnReordering) {
167 IncomingPacket(kBaseSeq, kBaseTimeMs);
168 IncomingPacket(kBaseSeq + 2, kBaseTimeMs + 2);
169
170 EXPECT_CALL(router_, SendFeedback(_))
171 .Times(1)
172 .WillOnce(Invoke([this](rtcp::TransportFeedback* packet) {
173 packet->Build();
174 EXPECT_EQ(kBaseSeq, packet->GetBaseSequence());
175 EXPECT_EQ(kMediaSsrc, packet->GetMediaSourceSsrc());
176
177 std::vector<int64_t> delta_vec = packet->GetReceiveDeltasUs();
178 EXPECT_EQ(2u, delta_vec.size());
179 EXPECT_EQ(kBaseTimeMs, (packet->GetBaseTimeUs() + delta_vec[0]) / 1000);
180 EXPECT_EQ(2, delta_vec[1] / 1000);
181 return true;
182 }));
183
184 Process();
185
186 IncomingPacket(kBaseSeq + 1, kBaseTimeMs + 1);
187
188 EXPECT_CALL(router_, SendFeedback(_))
189 .Times(1)
190 .WillOnce(Invoke([this](rtcp::TransportFeedback* packet) {
191 packet->Build();
192 EXPECT_EQ(kBaseSeq + 1, packet->GetBaseSequence());
193 EXPECT_EQ(kMediaSsrc, packet->GetMediaSourceSsrc());
194
195 std::vector<int64_t> delta_vec = packet->GetReceiveDeltasUs();
196 EXPECT_EQ(2u, delta_vec.size());
197 EXPECT_EQ(kBaseTimeMs + 1,
198 (packet->GetBaseTimeUs() + delta_vec[0]) / 1000);
199 EXPECT_EQ(1, delta_vec[1] / 1000);
200 return true;
201 }));
202
203 Process();
204 }
205
206 TEST_F(RemoteEstimatorProxyTest, RemovesTimestampsOutOfScope) {
207 const int64_t kTimeoutTimeMs =
208 kBaseTimeMs + RemoteEstimatorProxy::kBackWindowMs;
209
210 IncomingPacket(kBaseSeq + 2, kBaseTimeMs);
211
212 EXPECT_CALL(router_, SendFeedback(_))
213 .Times(1)
214 .WillOnce(Invoke([kTimeoutTimeMs, this](rtcp::TransportFeedback* packet) {
215 packet->Build();
216 EXPECT_EQ(kBaseSeq + 2, packet->GetBaseSequence());
217
218 std::vector<int64_t> delta_vec = packet->GetReceiveDeltasUs();
219 EXPECT_EQ(1u, delta_vec.size());
220 EXPECT_EQ(kBaseTimeMs, (packet->GetBaseTimeUs() + delta_vec[0]) / 1000);
221 return true;
222 }));
223
224 Process();
225
226 IncomingPacket(kBaseSeq + 3, kTimeoutTimeMs); // kBaseSeq + 2 times out here.
227
228 EXPECT_CALL(router_, SendFeedback(_))
229 .Times(1)
230 .WillOnce(Invoke([kTimeoutTimeMs, this](rtcp::TransportFeedback* packet) {
231 packet->Build();
232 EXPECT_EQ(kBaseSeq + 3, packet->GetBaseSequence());
233
234 std::vector<int64_t> delta_vec = packet->GetReceiveDeltasUs();
235 EXPECT_EQ(1u, delta_vec.size());
236 EXPECT_EQ(kTimeoutTimeMs,
237 (packet->GetBaseTimeUs() + delta_vec[0]) / 1000);
238 return true;
239 }));
240
241 Process();
242
243 // New group, with sequence starting below the first so that they may be
244 // retransmitted.
245 IncomingPacket(kBaseSeq, kBaseTimeMs - 1);
246 IncomingPacket(kBaseSeq + 1, kTimeoutTimeMs - 1);
247
248 EXPECT_CALL(router_, SendFeedback(_))
249 .Times(1)
250 .WillOnce(Invoke([kTimeoutTimeMs, this](rtcp::TransportFeedback* packet) {
251 packet->Build();
252 EXPECT_EQ(kBaseSeq, packet->GetBaseSequence());
253
254 // Four status entries (kBaseSeq + 3 missing).
255 EXPECT_EQ(4u, packet->GetStatusVector().size());
256
257 // Only three actual timestamps.
258 std::vector<int64_t> delta_vec = packet->GetReceiveDeltasUs();
259 EXPECT_EQ(3u, delta_vec.size());
260 EXPECT_EQ(kBaseTimeMs - 1,
261 (packet->GetBaseTimeUs() + delta_vec[0]) / 1000);
262 EXPECT_EQ(kTimeoutTimeMs - kBaseTimeMs, delta_vec[1] / 1000);
263 EXPECT_EQ(1, delta_vec[2] / 1000);
264 return true;
265 }));
266
267 Process();
268 }
269
270 } // namespace webrtc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698